FF-37 finished adding unit tests.

Author: open-schnick

src/main/java/de/filefighter/rest/health/business/SystemHealthModelAssembler.java

@@ -1,7 +1,7 @@
 package de.filefighter.rest.health.business;
 
 import de.filefighter.rest.health.data.SystemHealth;
-import de.filefighter.rest.health.rest.HealthRestController;
+import de.filefighter.rest.health.rest.SystemHealthRestController;
 import org.jetbrains.annotations.NotNull;
 import org.springframework.hateoas.EntityModel;
 import org.springframework.hateoas.server.RepresentationModelAssembler;
@@ -16,6 +16,6 @@ public class SystemHealthModelAssembler implements RepresentationModelAssembler<
     @Override
     public @NotNull EntityModel<SystemHealth> toModel(@NotNull SystemHealth entity) {
         return EntityModel.of(entity,
-                linkTo(methodOn(HealthRestController.class).getSystemHealthInfo()).withSelfRel());
+                linkTo(methodOn(SystemHealthRestController.class).getSystemHealthInfo()).withSelfRel());
     }
 }

src/main/java/de/filefighter/rest/health/data/SystemHealth.java

@@ -1,10 +1,14 @@
 package de.filefighter.rest.health.data;
 
 import lombok.Builder;
-import lombok.Data;
+import lombok.Getter;
 
-@Data
+/**
+ * This class is a representation of the json model.
+ */
+
+@Getter
 @Builder(buildMethodName = "create")
 public class SystemHealth {
-    private long uptimeInSeconds;
+    private final long uptimeInSeconds;
 }

src/main/java/de/filefighter/rest/health/rest/HealthRestController.java renamed to src/main/java/de/filefighter/rest/health/rest/SystemHealthRestController.java

@@ -4,16 +4,15 @@
 import io.swagger.annotations.Api;
 import org.springframework.hateoas.EntityModel;
 import org.springframework.web.bind.annotation.GetMapping;
-import org.springframework.web.bind.annotation.RequestMapping;
 import org.springframework.web.bind.annotation.RestController;
 
 @RestController
 @Api(value = "System Health", tags = { "SystemHealth" })
-public class HealthRestController {
+public class SystemHealthRestController {
 
-    private final HealthRestInterface healthRestService;
+    private final SystemHealthRestInterface healthRestService;
 
-    public HealthRestController(HealthRestInterface healthRestService) {
+    public SystemHealthRestController(SystemHealthRestInterface healthRestService) {
         this.healthRestService = healthRestService;
     }
 

src/main/java/de/filefighter/rest/health/rest/HealthRestInterface.java renamed to src/main/java/de/filefighter/rest/health/rest/SystemHealthRestInterface.java

@@ -3,6 +3,6 @@
 import de.filefighter.rest.health.data.SystemHealth;
 import org.springframework.hateoas.EntityModel;
 
-public interface HealthRestInterface {
+public interface SystemHealthRestInterface {
     EntityModel<SystemHealth> getSystemHealth();
 }

src/main/java/de/filefighter/rest/health/rest/HealthRestService.java renamed to src/main/java/de/filefighter/rest/health/rest/SystemHealthRestService.java

@@ -7,12 +7,12 @@
 import org.springframework.stereotype.Service;
 
 @Service
-public class HealthRestService implements HealthRestInterface{
+public class SystemHealthRestService implements SystemHealthRestInterface {
 
     private final SystemHealthBusinessService systemHealthBusinessService;
     private final SystemHealthModelAssembler systemHealthModelAssembler;
 
-    public HealthRestService(SystemHealthBusinessService systemHealthBusinessService, SystemHealthModelAssembler systemHealthModelAssembler) {
+    public SystemHealthRestService(SystemHealthBusinessService systemHealthBusinessService, SystemHealthModelAssembler systemHealthModelAssembler) {
         this.systemHealthBusinessService = systemHealthBusinessService;
         this.systemHealthModelAssembler = systemHealthModelAssembler;
     }

src/main/java/de/filefighter/rest/rest/ServerResponse.java

@@ -1,12 +1,13 @@
 package de.filefighter.rest.rest;
 
 import lombok.Data;
+import lombok.Getter;
 import org.springframework.hateoas.EntityModel;
 
-@Data
+@Getter
 public class ServerResponse {
-    private String message;
-    private String status;
+    private final String message;
+    private final String status;
 
     public ServerResponse(String status, String message) {
         this.status = status;

src/test/java/de/filefighter/rest/health/business/SystemHealthBusinessServiceUnitTest.java

@@ -1,7 +1,6 @@
 package de.filefighter.rest.health.business;
 
 import de.filefighter.rest.health.data.SystemHealth;
-import org.junit.Before;
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
 
@@ -11,10 +10,10 @@
 
 class SystemHealthBusinessServiceUnitTest {
 
-    private SystemHealthBusinessService systemHealthBusinessService;
+    private static SystemHealthBusinessService systemHealthBusinessService;
 
-    @Before
-    public void setUp(){
+    @BeforeAll
+    static void setUp() {
         systemHealthBusinessService = new SystemHealthBusinessService();
     }
 

src/test/java/de/filefighter/rest/health/business/SystemHealthModelAssemblerUnitTest.java

@@ -1,7 +1,6 @@
 package de.filefighter.rest.health.business;
 
 import de.filefighter.rest.health.data.SystemHealth;
-import org.junit.Before;
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
 import org.springframework.hateoas.EntityModel;
@@ -10,10 +9,10 @@
 
 class SystemHealthModelAssemblerUnitTest {
 
-    private SystemHealthModelAssembler systemHealthModelAssembler;
+    private static SystemHealthModelAssembler systemHealthModelAssembler;
 
-    @Before
-    public void setUp(){
+    @BeforeAll
+    static void setUp(){
         systemHealthModelAssembler = new SystemHealthModelAssembler();
     }
 
@@ -24,6 +23,6 @@ void toModel() {
 
         assertEquals(systemHealth, systemHealthEntityModel.getContent());
         assertTrue(systemHealthEntityModel.getLink("self").isPresent());
-        assertTrue(systemHealthEntityModel.getLink("ugabuga").isEmpty());
+        assertTrue(systemHealthEntityModel.getLink("thislinkdoesnotexist").isEmpty());
     }
 }

src/test/java/de/filefighter/rest/health/rest/HealthRestServiceUnitTest.java

@@ -0,0 +1,37 @@
+package de.filefighter.rest.health.rest;
+
+import de.filefighter.rest.health.business.SystemHealthBusinessService;
+import de.filefighter.rest.health.business.SystemHealthModelAssembler;
+import de.filefighter.rest.health.data.SystemHealth;
+import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.Test;
+import org.springframework.hateoas.EntityModel;
+
+import static org.junit.jupiter.api.Assertions.*;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.when;
+
+class HealthRestServiceUnitTest {
+
+    private static final SystemHealthBusinessService systemHealthBusinessServiceMock = mock(SystemHealthBusinessService.class);
+    private static final SystemHealthModelAssembler systemHealthModelAssemblerMock = mock(SystemHealthModelAssembler.class);
+    private static SystemHealthRestService systemHealthRestService;
+
+    @BeforeAll
+    public static void setUp() {
+        systemHealthRestService = new SystemHealthRestService(systemHealthBusinessServiceMock, systemHealthModelAssemblerMock);
+    }
+
+    @Test
+    void getSystemHealth() {
+        SystemHealth dummyHealth = SystemHealth.builder().uptimeInSeconds(420).create();
+        EntityModel<SystemHealth> actualModell = EntityModel.of(dummyHealth);
+
+        when(systemHealthBusinessServiceMock.getCurrentSystemHealthInfo()).thenReturn(dummyHealth);
+        when(systemHealthModelAssemblerMock.toModel(dummyHealth)).thenReturn(actualModell);
+
+        EntityModel<SystemHealth> expectedModel = systemHealthRestService.getSystemHealth();
+
+        assertEquals(expectedModel, actualModell);
+    }
+}

src/test/java/de/filefighter/rest/health/rest/SystemHealthRestControllerUnitTest.java

@@ -0,0 +1,36 @@
+package de.filefighter.rest.health.rest;
+
+import de.filefighter.rest.rest.RestErrorController;
+import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.Test;
+import org.springframework.test.web.servlet.MockMvc;
+import org.springframework.test.web.servlet.setup.MockMvcBuilders;
+
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.junit.jupiter.api.Assertions.*;
+import static org.mockito.ArgumentMatchers.isA;
+import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get;
+import static org.mockito.Mockito.*;
+import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;
+
+class SystemHealthRestControllerUnitTest {
+
+    private static MockMvc mockMvc;
+    private static SystemHealthRestService systemHealthRestServiceMock = mock(SystemHealthRestService.class);
+    private static SystemHealthRestController systemHealthRestController;
+
+    @BeforeAll
+    public static void setUp() {
+        systemHealthRestController = new SystemHealthRestController(systemHealthRestServiceMock);
+        mockMvc = MockMvcBuilders.standaloneSetup(systemHealthRestController).build();
+    }
+
+    @Test
+    void getSystemHealthInfo() throws Exception {
+        mockMvc.perform(get("/health"))
+                .andExpect(status().isOk())
+                .andReturn();
+
+        verify(systemHealthRestServiceMock, times(1)).getSystemHealth();
+    }
+}