Added missing check in UserAuthorizationService.authenticateUserWithUsernameAndPassword

Author: open-schnick

src/main/java/de/filefighter/rest/domain/user/business/UserAuthorizationService.java

@@ -29,7 +29,7 @@ public UserAuthorizationService(UserRepository userRepository, UserDtoService us
     }
 
     public User authenticateUserWithUsernameAndPassword(String base64encodedUserAndPassword) {
-        String decodedUsernameAndPassword = "";
+        String decodedUsernameAndPassword;
         try {
             byte[] decodedValue = Base64.getDecoder().decode(base64encodedUserAndPassword);
             decodedUsernameAndPassword = new String(decodedValue, StandardCharsets.UTF_8);

src/test/java/de/filefighter/rest/domain/user/business/UserAuthorizationServiceUnitTest.java

@@ -26,11 +26,16 @@ class UserAuthorizationServiceUnitTest {
     void authenticateUserWithUsernameAndPasswordThrows() {
         String matchesButIsNotSupportedEncoding = "���"; //funny enough sonar doesnt like this. who cares.
         String matchesButUserWasNotFound = "dXNlcjpwYXNzd29yZA==";
+        String onlyContainsUsername = "dXNlcm5hbWU=";
 
         RuntimeException ex = assertThrows(RequestDidntMeetFormalRequirementsException.class, () ->
                 userAuthorizationService.authenticateUserWithUsernameAndPassword(matchesButIsNotSupportedEncoding));
         assertEquals("Request didnt meet formal requirements. Found unsupported character in header.", ex.getMessage());
 
+        ex = assertThrows(RequestDidntMeetFormalRequirementsException.class, () ->
+                userAuthorizationService.authenticateUserWithUsernameAndPassword(onlyContainsUsername));
+        assertEquals("Request didnt meet formal requirements. Credentials didnt meet formal requirements.", ex.getMessage());
+
         when(userRepositoryMock.findByLowercaseUsernameAndPassword("user", "password")).thenReturn(null);
 
         ex = assertThrows(UserNotAuthenticatedException.class, () ->