FF-423 add check if filename is valid before uploading of single file (#166)

* add check if filename is valid before uploading of single file

* add videoUploadOnPasses to cypress config

Author: qvalentin

cypress.json

@@ -1,4 +1,5 @@
 {
   "baseUrl": "http://localhost:3000",
-  "projectId": "57baod"
+  "projectId": "57baod",
+  "videoUploadOnPasses": false
 }

src/background/methods/filesystem.ts

@@ -29,7 +29,8 @@ export const getFileExtension = (fileName: string): string => {
     return reverseString(reverseString(fileName).substr(0, positionOfPoint));
 };
 
-export const getMimeType = (fileName: string): string => {
-    let positionOfFirstSlash = fileName.indexOf("/");
-    return fileName.substr(0, positionOfFirstSlash);
-};
+export const isFileNameValid = (name: string) =>{
+    return !(!name ||
+        name.includes("/") ||
+        name.match("[~#@*+:!?&%<>|\"^\\\\]"))
+}

src/components/pages/filesytem/ToolbarActions.tsx

@@ -21,9 +21,6 @@ function ToolbarActions(props: Props): ReactElement | null {
         deleteFsEntities(props.selectedFsEntities);
     }
 
-    /*    function handleDownloadClicked() {
-            downloadFiles(props.selectedFsEntities)
-        } */
 
     return (
         <span>

src/components/pages/filesytem/upload/UploadZone.tsx

@@ -7,7 +7,7 @@ import { uploadFiles, uploadPreflight } from "../../../../background/api/filesys
 import { FsEntity } from "../../../../background/api/filesystemTypes";
 import { UploadDecisionsModalContent } from "./UploadDecisionsModalContent";
 import { divideArrayByCondition } from "../../../../background/methods/arrays";
-import { getPathWithoutName } from "../../../../background/methods/filesystem";
+import { getPathWithoutName, isFileNameValid } from "../../../../background/methods/filesystem";
 import {
   EditableEntityError,
   EditableFileWithPreflightInfo,
@@ -50,7 +50,7 @@ export const UploadZone = (): ReactElement => {
       let preflightNeeded = acceptedFiles.some(
         (file: EditablePreflightEntityOrFile) => {
           return (
-            file.path.includes("/") ||
+            file.path.includes("/") || !isFileNameValid(file.name) ||
             currentFsContent.some(
               (fsEntiy: FsEntity) => fsEntiy.name === file.name
             )
@@ -197,13 +197,9 @@ export const preflightResultReducer: Reducer<EditablePreflightEntityOrFile[],
         }
       );
 
-      let newNameIsValidNot =
-        !action.payload.newName ||
-        action.payload.newName.includes("/") ||
-        action.payload.newName.includes(" ") ||
-        action.payload.newName.match("[~#@*+:!?&%<>|\"^\\\\]");
+      let newNameIsNotValid = !isFileNameValid(action.payload.newName)
 
-      if (newPathAlreadyExits || newNameIsValidNot) {
+      if (newPathAlreadyExits || newNameIsNotValid) {
         elementToReplace.error = newPathAlreadyExits
           ? EditableEntityError.ALREADYEXITS
           : EditableEntityError.INVALIDNAME;