Skip to content

Commit 228897d

Browse files
author
Filip Nikolovski
committed
fix tests for falcon 1 & 2
1 parent 2d68dc5 commit 228897d

File tree

1 file changed

+10
-1
lines changed
  • instrumentation/opentelemetry-instrumentation-falcon/tests

1 file changed

+10
-1
lines changed

instrumentation/opentelemetry-instrumentation-falcon/tests/test_falcon.py

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,16 @@ def test_500(self):
186186
self.assertEqual(span.name, "GET /error")
187187
self.assertFalse(span.status.is_ok)
188188
self.assertEqual(span.status.status_code, StatusCode.ERROR)
189-
self.assertEqual(span.status.description, None)
189+
190+
_parsed_falcon_version = package_version.parse(_falcon_version)
191+
if _parsed_falcon_version < package_version.parse("3.0.0"):
192+
self.assertEqual(
193+
span.status.description,
194+
"NameError: name 'non_existent_var' is not defined",
195+
)
196+
else:
197+
self.assertEqual(span.status.description, None)
198+
190199
self.assertSpanHasAttributes(
191200
span,
192201
{

0 commit comments

Comments
 (0)