refactor: apply all Biome fixes

This is a very big commit with a lot of whitespace changes due to slight
differences between Prettier and Biome's formatting.

I think it can mostly be ignored as everything _should_ be safe and not
impact any end-users.

Author: rowanmanning

biome.json

@@ -11,6 +11,13 @@
 		"indentWidth": 4,
 		"lineWidth": 100
 	},
+	"linter": {
+		"rules": {
+			"suspicious": {
+				"noExplicitAny": "off"
+			}
+		}
+	},
 	"javascript": {
 		"formatter": {
 			"quoteStyle": "single",

packages/app-info/lib/index.js

@@ -31,8 +31,7 @@ const manifestName =
 		: null;
 
 /** @type {string | null} */
-const manifestVersion =
-	typeof manifest?.version === 'string' ? manifest.version : null;
+const manifestVersion = typeof manifest?.version === 'string' ? manifest.version : null;
 
 /**
  * Extract the process type from a Heroku dyno name.
@@ -74,10 +73,7 @@ const cloudProvider = () => {
  * @type {string | null}
  */
 exports.commitHash =
-	process.env.HEROKU_SLUG_COMMIT ||
-	process.env.GIT_COMMIT_LONG ||
-	process.env.GIT_COMMIT ||
-	null;
+	process.env.HEROKU_SLUG_COMMIT || process.env.GIT_COMMIT_LONG || process.env.GIT_COMMIT || null;
 
 /**
  * The application deployment environment.
@@ -187,6 +183,5 @@ exports.semanticConventions = {
 	}
 };
 
-// @ts-expect-error
 module.exports.default = module.exports;
 module.exports = Object.freeze(module.exports);

packages/client-metrics-web/lib/index.js

@@ -113,9 +113,7 @@ exports.MetricsClient = class MetricsClient {
 	#handleMetricsEvent = (event) => {
 		try {
 			if (event instanceof CustomEvent) {
-				const { namespace, ...data } = MetricsClient.#resolveEventDetail(
-					event.detail
-				);
+				const { namespace, ...data } = MetricsClient.#resolveEventDetail(event.detail);
 				this.recordEvent(namespace, data);
 			}
 		} catch (/** @type {any} */ error) {
@@ -205,9 +203,7 @@ exports.MetricsClient = class MetricsClient {
 			throw new TypeError('detail must be an object');
 		}
 		if (typeof detail.namespace !== 'string') {
-			throw new TypeError(
-				`detail.namespace (${typeof detail.namespace}) must be a string`
-			);
+			throw new TypeError(`detail.namespace (${typeof detail.namespace}) must be a string`);
 		}
 		return detail;
 	}

packages/client-metrics-web/test/unit/lib/index.spec.js

@@ -182,9 +182,7 @@ describe('@dotcom-reliability-kit/client-metrics-web', () => {
 
 			it('hands the error to the AWS RUM client', () => {
 				expect(AwsRum.mock.instances[0].recordError).toHaveBeenCalledTimes(1);
-				expect(AwsRum.mock.instances[0].recordError).toHaveBeenCalledWith(
-					error
-				);
+				expect(AwsRum.mock.instances[0].recordError).toHaveBeenCalledWith(error);
 			});
 		});
 

packages/client-metrics-web/types/index.d.ts

@@ -10,12 +10,12 @@ declare module '@dotcom-reliability-kit/client-metrics-web' {
 	};
 
 	export class MetricsClient {
-		constructor(options: MetricsClientOptions): MetricsClient;
+		constructor(options: MetricsClientOptions);
 		get isAvailable(): boolean;
 		get isEnabled(): boolean;
 		enable(): void;
 		disable(): void;
-		recordError(error: unknown): void;
+		recordError(error: any): void;
 		recordEvent(namespace: string, eventData?: Record<string, any>): void;
 	}
 

packages/crash-handler/lib/index.js

@@ -1,7 +1,4 @@
-const {
-	logHandledError,
-	logUnhandledError
-} = require('@dotcom-reliability-kit/log-error');
+const { logHandledError, logUnhandledError } = require('@dotcom-reliability-kit/log-error');
 
 /**
  * @import { CrashHandlerOptions } from '@dotcom-reliability-kit/crash-handler'

packages/crash-handler/package.json

@@ -16,6 +16,7 @@
   "main": "lib/index.js",
   "types": "types/index.d.ts",
   "dependencies": {
+    "@dotcom-reliability-kit/logger": "^4.2.6",
     "@dotcom-reliability-kit/log-error": "^5.1.6"
   }
 }

packages/crash-handler/test/unit/lib/index.spec.js

@@ -4,10 +4,7 @@ jest.mock('@dotcom-reliability-kit/log-error', () => ({
 	logHandledError: jest.fn(),
 	logUnhandledError: jest.fn()
 }));
-const {
-	logHandledError,
-	logUnhandledError
-} = require('@dotcom-reliability-kit/log-error');
+const { logHandledError, logUnhandledError } = require('@dotcom-reliability-kit/log-error');
 
 describe('@dotcom-reliability-kit/crash-handler', () => {
 	describe('.default', () => {
@@ -33,10 +30,7 @@ describe('@dotcom-reliability-kit/crash-handler', () => {
 
 		it('binds a handler to the process `uncaughtException` event', () => {
 			expect(mockProcess.on).toHaveBeenCalledTimes(1);
-			expect(mockProcess.on).toHaveBeenCalledWith(
-				'uncaughtException',
-				expect.any(Function)
-			);
+			expect(mockProcess.on).toHaveBeenCalledWith('uncaughtException', expect.any(Function));
 		});
 
 		describe('uncaughtExceptionHandler(error)', () => {

packages/errors/lib/base-error.js

@@ -113,7 +113,7 @@ class BaseError extends Error {
 	 * @type {(typeof BaseErrorType)['isErrorMarkedAsOperational']}
 	 */
 	static isErrorMarkedAsOperational(error) {
-		// @ts-ignore Error.prototype.isOperational does not exist, but it's OK to check in this
+		// @ts-expect-error Error.prototype.isOperational does not exist, but it's OK to check in this
 		// case as we're manually casting `undefined` to a Boolean
 		return Boolean(error.isOperational);
 	}

packages/errors/lib/http-error.js

@@ -12,7 +12,7 @@ const OperationalError = require('./operational-error');
  * @see HttpError.getMessageForStatusCode
  * @type {{[key: string]: any}}
  */
-const STATUS_CODES = require('http').STATUS_CODES;
+const STATUS_CODES = require('node:http').STATUS_CODES;
 
 /**
  * Class representing an HTTP error.
@@ -117,11 +117,7 @@ class HttpError extends OperationalError {
 	 * @protected
 	 * @type {string[]}
 	 */
-	static reservedKeys = [
-		...OperationalError.reservedKeys,
-		'statusCode',
-		'statusMessage'
-	];
+	static reservedKeys = [...OperationalError.reservedKeys, 'statusCode', 'statusMessage'];
 
 	/**
 	 * @protected