Merge pull request #276 from Financial-Times/apaleslimghost-patch-1

feat: print location header for an unexpected redirect in status check

Author: apaleslimghost

lib/checks/status.js

@@ -10,6 +10,11 @@ const outputErrorInfo = async (testPage) => {
 	`;
 };
 
+const outputRedirectInfo = (testPage) => {
+	const headers = testPage.response.headers();
+	return `Status = ${testPage.status}. Redirected to ${headers['location']}`;
+}
+
 module.exports = async (testPage) => {
 	if (testPage.check.status === 204) {
 		//eslint-disable-next-line no-console
@@ -22,10 +27,16 @@ module.exports = async (testPage) => {
 			result: testPage.redirect && testPage.check.status === testPage.redirect.to
 		};
 	} else {
+		const redirectStatusCodes = [301, 302, 307, 308]
 		const isUnexpectedHttpError = testPage.check.status !== 500 && testPage.status === 500;
+		const isUnexpectedRedirect = !redirectStatusCodes.includes(testPage.check.status) && redirectStatusCodes.includes(testPage.status)
 		return {
 			expected: `Status = ${testPage.check.status}`,
-			actual: isUnexpectedHttpError ? await outputErrorInfo(testPage) : `Status = ${testPage.status}`,
+			actual: (
+				isUnexpectedHttpError ? await outputErrorInfo(testPage)
+				: isUnexpectedRedirect ? outputRedirectInfo(testPage)
+				: `Status = ${testPage.status}`
+			),
 			result: testPage.status === testPage.check.status || testPage.status === 304 && testPage.check.status === 200
 		};
 	}