Skip to content

Switch to TenantInfo over ITenantInfo seemed unnecessary #1073

@atrauzzi

Description

@atrauzzi

Going through the steps to upgrade to 10.x. The shift to forcing a record for the TenantInfo type (and thus the implementer), along with a non-parameterless constructor is sadly a step backwards in overall library design with an underestimated impact.

Anyone who is implementing the Tenant object itself can always use required properties to enforce them if they don't want to use a constructor. The interface getters were sufficient to ensure that library code could get what it needs. Implementers are now forced into a single approach to provide an id, identifier, and name. Whereas prior, there was the option to provide a default value to the property. A similar concern exists around using a record vs class (personally, I don't care, but again, the library has no reason to be prescriptive on this).

This has removed a lot of flexibility from the library without necessarily demonstrating any benefit over what was already in place.

Would love to see the interface restored (getter-only would suffice).

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions