-
Notifications
You must be signed in to change notification settings - Fork 3
Open
Labels
bugSomething isn't workingSomething isn't workingenhancementNew feature or requestNew feature or request
Milestone
Description
Right now the AttributedModelSourceGenerator doesn't do extra checks (e.g. return type checks) which means that it'll cause compilation errors if used incorrectly.
For example:
[Group("test")]
public class TestModule : Module
{
[Command("test")]
public void DoThing()
{ }
}Will likely produce a class something like this:
internal class CommandFactory__TestModule__DoThing : ICommand
{
public async ValueTask<ICommandResult> ExecuteAsync(...)
{
var commandClass = new TestModule(...);
...
return await commandClass.DoThing();
...
}
}Which, as you can imagine, won't work.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingenhancementNew feature or requestNew feature or request