NeoForge PR#1915 (21.4.84-beta [1.21.x]) breaks mixins reload listeners

[NunyaBiznass]

From NeoForge PR#1915:

This PR introduces dependency sorting for both client and server reload listeners. The sort is topological, using FML's TopologicalSort class as the backbone. Reload listeners are added to a DAG where an edge from a->b means that a must run before b.

The sorting logic, and the modder-facing API, is in SortedReloadListenerEvent, the parent class of both AddServerReloadListenersEvent and AddClientReloadListenersEvent (formerly RegisterClientReloadListenersEvent).

Requirements
As a prerequisite, this change enforces that all reload listeners are named. The name must be provided via SortedReloadListenerEvent#addListener at the time of registration. Vanilla listeners are automatically named, via VanillaClientListeners and VanillaServerListeners, which hold the class->RL maps for all known vanilla listener types.

Note: Mods that are currently using mixins or other non-event means to inject reload listeners will crash after this change.

[scharyu]

Got crashed on NeoForge with:

java.lang.NoClassDefFoundError: net/neoforged/neoforge/client/event/RegisterClientReloadListenersEvent

I assume it regards to this topic. I also assume that we (users) aren't able to fix it, only wait for patches, are we?

[NunyaBiznass]

Any way to get eyes on this?

I don't know enough about the Embeddium design to code a fix; but so far as I can tell, the deprecated class RegisterClientReloadListenersEvent is being called by the SpriteFinderCache.