Merge pull request #28 from FireTail-io/hotfix/bad-json-dumps

Remove bad json dumps from resolve_and_validate_openapi_spec

Author: rileyfiretail

src/openapi/validation.py

@@ -9,7 +9,7 @@
 
 def resolve_and_validate_openapi_spec(file_contents: str) -> dict | None:
     parser = prance.ResolvingParser(
-        spec_string=json.dumps(file_contents),
+        spec_string=file_contents,
         resolve_types=RESOLVE_INTERNAL,
         backend="openapi-spec-validator",
         lazy=True,
@@ -23,19 +23,21 @@ def resolve_and_validate_openapi_spec(file_contents: str) -> dict | None:
 
 
 def parse_resolve_and_validate_openapi_spec(file_path: str, get_file_contents: Callable[[], str]) -> dict | None:
+    # First check it's a valid JSON/YAML file before passing it over to Prance
     if file_path.endswith(".json"):
         try:
-            file_contents = json.loads(get_file_contents())
+            json.loads(get_file_contents())
         except:  # noqa: E722
             return None
 
     elif file_path.endswith((".yaml", ".yml")):
         try:
-            file_contents = yaml.safe_load(get_file_contents())
+            yaml.safe_load(get_file_contents())
         except:  # noqa: E722
             return None
 
     else:
         return None
-
-    return resolve_and_validate_openapi_spec(file_contents)
+    
+    # If it was a valid JSON/YAML file, we can give it to Prance to load
+    return resolve_and_validate_openapi_spec(get_file_contents())