Skip to content

Commit b9edd24

Browse files
authored
set expiry flag (#22)
1 parent a17a591 commit b9edd24

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

README.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -86,9 +86,7 @@ build log.
8686
8787
### `expires` _{string}_
8888

89-
> ⚠️ This option isn't supported yet. If you set it, it will be ignored. See [issue #7](https://github.com/FirebaseExtended/action-hosting-deploy/issues/7) for context.
90-
91-
The length of time the channel should live. Default is 7 days.
89+
The length of time the channel should live. If left blank, uses the Firebase Hosting default expiry (7 days).
9290

9391
### `projectId` _{string}_
9492

bin/action.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/deploy.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,11 @@ export async function deploy(gacFilename: string, deployConfig: DeployConfig) {
9999

100100
const deploymentText = await execWithCredentials(
101101
"npx firebase-tools",
102-
["hosting:channel:deploy", channelId],
102+
[
103+
"hosting:channel:deploy",
104+
channelId,
105+
...(expires ? ["--expires", expires] : []),
106+
],
103107
projectId,
104108
gacFilename
105109
);

0 commit comments

Comments
 (0)