Merge pull request #389 from firebase/release_0.8.1_idfix

Fixes #387 & #376 - set id on init instead of each update

Author: Jacob Wenger

dist/angularfire.js

@@ -134,10 +134,15 @@
          */
         $save: function(indexOrItem) {
           this._assertNotDestroyed('$save');
-          var item = this._resolveItem(indexOrItem);
-          var key = this.$keyAt(item);
+          var self = this;
+          var item = self._resolveItem(indexOrItem);
+          var key = self.$keyAt(item);
           if( key !== null ) {
-            return this.$inst().$set(key, $firebaseUtils.toJSON(item));
+            return self.$inst().$set(key, $firebaseUtils.toJSON(item))
+              .then(function(ref) {
+                self._notify('child_changed', key);
+                return ref;
+              });
           }
           else {
             return $firebaseUtils.reject('Invalid record; could determine its key: '+indexOrItem);
@@ -600,12 +605,12 @@
             }
             // be sure to do this after setting up data and init state
             angular.forEach(self.$$conf.listeners, function (parts) {
-              parts[0].call(parts[1], {event: 'updated', key: self.$id});
+              parts[0].call(parts[1], {event: 'value', key: self.$id});
             });
           }
         };
 
-        self.$id = $firebase.$ref().name();
+        self.$id = $firebase.$ref().ref().name();
         self.$priority = null;
       }
 
@@ -615,7 +620,12 @@
          * @returns a promise which will resolve after the save is completed.
          */
         $save: function () {
-          return this.$inst().$set($firebaseUtils.toJSON(this));
+          var notify = this.$$conf.notify;
+          return this.$inst().$set($firebaseUtils.toJSON(this))
+            .then(function(ref) {
+              notify();
+              return ref;
+            });
         },
 
         /**
@@ -758,7 +768,6 @@
         $$updated: function (snap) {
           // applies new data to this object
           var changed = $firebaseUtils.updateRec(this, snap);
-          this.$id = snap.name();
           if( changed ) {
             // notifies $watch listeners and
             // updates $scope if bound to a variable

dist/angularfire.min.js

@@ -110,7 +110,7 @@
               .then(function(ref) {
                 self._notify('child_changed', key);
                 return ref;
-              })
+              });
           }
           else {
             return $firebaseUtils.reject('Invalid record; could determine its key: '+indexOrItem);

src/FirebaseArray.js

@@ -64,7 +64,7 @@
           }
         };
 
-        self.$id = $firebase.$ref().name();
+        self.$id = $firebase.$ref().ref().name();
         self.$priority = null;
       }
 
@@ -222,7 +222,6 @@
         $$updated: function (snap) {
           // applies new data to this object
           var changed = $firebaseUtils.updateRec(this, snap);
-          this.$id = snap.name();
           if( changed ) {
             // notifies $watch listeners and
             // updates $scope if bound to a variable

src/FirebaseObject.js

@@ -671,6 +671,7 @@ describe('$FirebaseArray', function () {
     }
   })();
 
+  //todo abstract into testutils
   function stubFb() {
     var ref = testutils.ref();
     var fb = {};

tests/unit/FirebaseArray.spec.js

@@ -28,6 +28,19 @@ describe('$FirebaseObject', function() {
     });
   });
 
+  describe('constructor', function() {
+    it('should set the record id', function() {
+      expect(obj.$id).toEqual($fb.$ref().name());
+    });
+
+    it('should accept a query', function() {
+      var obj = makeObject(FIXTURE_DATA, $fb.$ref().limit(1).startAt(null));
+      obj.$$updated(testutils.snap({foo: 'bar'}));
+      flushAll();
+      expect(obj).toEqual(jasmine.objectContaining({foo: 'bar'}));
+    });
+  });
+
   describe('$save', function () {
     it('should call $firebase.$set', function () {
       obj.foo = 'bar';
@@ -417,9 +430,9 @@ describe('$FirebaseObject', function() {
     });
 
     it('should preserve the id', function() {
-      var oldId = obj.$id;
+      obj.$id = 'change_id_for_test';
       obj.$$updated(fakeSnap(true));
-      expect(obj.$id).toBe(oldId);
+      expect(obj.$id).toBe('change_id_for_test');
     });
 
     it('should set the priority', function() {
@@ -463,8 +476,9 @@ describe('$FirebaseObject', function() {
     return testutils.refSnap(testutils.ref('data/a'), data, pri);
   }
 
-  function stubFb() {
-    var ref = testutils.ref('data/a');
+  //todo abstract into testutils
+  function stubFb(ref) {
+    if( !ref ) { ref = testutils.ref('data/a'); }
     var fb = {};
     [
       '$set', '$update', '$remove', '$transaction', '$asArray', '$asObject', '$ref', '$push'
@@ -497,10 +511,10 @@ describe('$FirebaseObject', function() {
 
   function noop() {}
 
-  function makeObject(initialData) {
+  function makeObject(initialData, ref) {
     var readyFuture = $utils.defer();
     var destroyFn = jasmine.createSpy('destroyFn');
-    var fb = stubFb();
+    var fb = stubFb(ref);
     var obj = new $FirebaseObject(fb, destroyFn, readyFuture.promise);
     obj.$$$readyFuture = readyFuture;
     obj.$$$destroyFn = destroyFn;