Skip to content
This repository was archived by the owner on Mar 17, 2025. It is now read-only.

Commit 39d8719

Browse files
bendruckerJacob Wenger
authored andcommitted
Ensure all global dependencies are loaded for CommonJS (#708)
1 parent ead7344 commit 39d8719

File tree

2 files changed

+10
-1
lines changed

2 files changed

+10
-1
lines changed

index.js

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,9 @@
1+
// Make sure dependencies are loaded on the window
2+
require('angular');
3+
require('firebase');
4+
5+
// Load the Angular module which uses window.angular and window.Firebase
16
require('./dist/angularfire');
7+
8+
// Export the module name from the Angular module
29
module.exports = 'firebase';

package.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,15 @@
2626
"README.md",
2727
"package.json"
2828
],
29-
"dependencies": {
29+
"peerDependencies": {
3030
"angular": "^1.3.0",
3131
"firebase": "2.x.x"
3232
},
3333
"devDependencies": {
34+
"angular": "^1.3.0",
3435
"angular-mocks": "~1.4.6",
3536
"coveralls": "^2.11.2",
37+
"firebase": "2.x.x",
3638
"grunt": "~0.4.5",
3739
"grunt-cli": "^0.1.13",
3840
"grunt-contrib-concat": "^0.5.0",

0 commit comments

Comments
 (0)