Skip to content
This repository was archived by the owner on Mar 17, 2025. It is now read-only.

Commit 3a6cae3

Browse files
committed
Merge pull request #547 from firebase/jw-update-deps
Updated npm and bower dependencies
2 parents 53ace60 + c05f1da commit 3a6cae3

File tree

4 files changed

+36
-39
lines changed

4 files changed

+36
-39
lines changed

bower.json

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,7 @@
3434
"firebase": "2.1.x"
3535
},
3636
"devDependencies": {
37-
"lodash": "~2.4.1",
38-
"angular-mocks": "~1.2.18",
39-
"mockfirebase": "~0.7.0"
37+
"angular-mocks": "~1.3.11",
38+
"mockfirebase": "~0.8.0"
4039
}
4140
}

package.json

Lines changed: 23 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -35,29 +35,30 @@
3535
"firebase": "2.1.x"
3636
},
3737
"devDependencies": {
38-
"coveralls": "^2.11.1",
39-
"grunt": "~0.4.1",
38+
"coveralls": "^2.11.2",
39+
"grunt": "~0.4.5",
4040
"grunt-cli": "^0.1.13",
41-
"grunt-contrib-concat": "^0.4.0",
42-
"grunt-contrib-connect": "^0.7.1",
43-
"grunt-contrib-jshint": "~0.10.0",
44-
"grunt-contrib-uglify": "~0.2.2",
45-
"grunt-contrib-watch": "~0.5.1",
46-
"grunt-karma": "~0.8.3",
47-
"grunt-notify": "~0.2.7",
48-
"grunt-protractor-runner": "^1.0.0",
49-
"grunt-shell-spawn": "^0.3.0",
50-
"jasmine-spec-reporter": "^0.4.0",
51-
"karma": "~0.12.0",
52-
"karma-chrome-launcher": "^0.1.4",
53-
"karma-coverage": "^0.2.4",
54-
"karma-failed-reporter": "0.0.2",
41+
"grunt-contrib-concat": "^0.5.0",
42+
"grunt-contrib-connect": "^0.9.0",
43+
"grunt-contrib-jshint": "^0.11.0",
44+
"grunt-contrib-uglify": "^0.7.0",
45+
"grunt-contrib-watch": "^0.6.1",
46+
"grunt-karma": "^0.10.1",
47+
"grunt-notify": "^0.4.1",
48+
"grunt-protractor-runner": "^1.2.1",
49+
"grunt-shell-spawn": "^0.3.1",
50+
"jasmine-core": "^2.1.3",
51+
"jasmine-spec-reporter": "^2.1.0",
52+
"karma": "~0.12.31",
53+
"karma-chrome-launcher": "^0.1.7",
54+
"karma-coverage": "^0.2.7",
55+
"karma-failed-reporter": "0.0.3",
5556
"karma-html2js-preprocessor": "~0.1.0",
56-
"karma-jasmine": "~0.2.0",
57-
"karma-phantomjs-launcher": "~0.1.0",
58-
"karma-sauce-launcher": "~0.2.9",
59-
"karma-spec-reporter": "0.0.13",
60-
"load-grunt-tasks": "~0.2.0",
61-
"protractor": "^1.0.0"
57+
"karma-jasmine": "^0.3.5",
58+
"karma-phantomjs-launcher": "~0.1.4",
59+
"karma-sauce-launcher": "~0.2.10",
60+
"karma-spec-reporter": "0.0.16",
61+
"load-grunt-tasks": "^3.1.0",
62+
"protractor": "^1.6.1"
6263
}
6364
}

tests/protractor/chat/chat.spec.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@ var protractor = require('protractor');
22
var Firebase = require('firebase');
33

44
describe('Chat App', function () {
5-
// Protractor instance
6-
var ptor = protractor.getInstance();
7-
85
// Reference to the Firebase which stores the data for this demo
96
var firebaseRef = new Firebase('https://angularFireTests.firebaseio-demo.com/chat');
107

@@ -148,4 +145,4 @@ describe('Chat App', function () {
148145
expect(messages.count()).toBe(0);
149146
expect(messagesCount.getText()).toEqual('0');
150147
});
151-
});
148+
});

tests/unit/firebase.spec.js

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -136,11 +136,11 @@ describe('$firebase', function () {
136136
it('should reject if fails', function() {
137137
var whiteSpy = jasmine.createSpy('resolve');
138138
var blackSpy = jasmine.createSpy('reject');
139-
$fb.$ref().failNext('push', 'failpush');
139+
$fb.$ref().failNext('push', new Error('failpush'));
140140
$fb.$push({foo: 'bar'}).then(whiteSpy, blackSpy);
141141
flushAll();
142142
expect(whiteSpy).not.toHaveBeenCalled();
143-
expect(blackSpy).toHaveBeenCalledWith('failpush');
143+
expect(blackSpy).toHaveBeenCalledWith(new Error('failpush'));
144144
});
145145

146146
it('should save correct data into Firebase', function() {
@@ -206,13 +206,13 @@ describe('$firebase', function () {
206206
});
207207

208208
it('should reject if fails', function() {
209-
$fb.$ref().failNext('set', 'setfail');
209+
$fb.$ref().failNext('set', new Error('setfail'));
210210
var whiteSpy = jasmine.createSpy('resolve');
211211
var blackSpy = jasmine.createSpy('reject');
212212
$fb.$set({foo: 'bar'}).then(whiteSpy, blackSpy);
213213
flushAll();
214214
expect(whiteSpy).not.toHaveBeenCalled();
215-
expect(blackSpy).toHaveBeenCalledWith('setfail');
215+
expect(blackSpy).toHaveBeenCalledWith(new Error('setfail'));
216216
});
217217

218218
it('should affect query keys only if query used', function() {
@@ -285,11 +285,11 @@ describe('$firebase', function () {
285285
it('should reject if fails', function() {
286286
var whiteSpy = jasmine.createSpy('resolve');
287287
var blackSpy = jasmine.createSpy('reject');
288-
$fb.$ref().failNext('remove', 'test_fail_remove');
288+
$fb.$ref().failNext('remove', new Error('test_fail_remove'));
289289
$fb.$remove().then(whiteSpy, blackSpy);
290290
flushAll();
291291
expect(whiteSpy).not.toHaveBeenCalled();
292-
expect(blackSpy).toHaveBeenCalledWith('test_fail_remove');
292+
expect(blackSpy).toHaveBeenCalledWith(new Error('test_fail_remove'));
293293
});
294294

295295
it('should remove data in Firebase', function() {
@@ -371,11 +371,11 @@ describe('$firebase', function () {
371371
it('should reject if failed', function() {
372372
var whiteSpy = jasmine.createSpy('resolve');
373373
var blackSpy = jasmine.createSpy('reject');
374-
$fb.$ref().failNext('update', 'oops');
374+
$fb.$ref().failNext('update', new Error('oops'));
375375
$fb.$update({index: {foo: 'bar'}}).then(whiteSpy, blackSpy);
376376
flushAll();
377377
expect(whiteSpy).not.toHaveBeenCalled();
378-
expect(blackSpy).toHaveBeenCalled();
378+
expect(blackSpy).toHaveBeenCalledWith(new Error('oops'));
379379
});
380380

381381
it('should not destroy untouched keys', function() {
@@ -435,11 +435,11 @@ describe('$firebase', function () {
435435
it('should reject if failed', function() {
436436
var whiteSpy = jasmine.createSpy('success');
437437
var blackSpy = jasmine.createSpy('failed');
438-
$fb.$ref().child('a').failNext('transaction', 'test_fail');
438+
$fb.$ref().child('a').failNext('transaction', new Error('test_fail'));
439439
$fb.$transaction('a', function() { return true; }).then(whiteSpy, blackSpy);
440440
flushAll();
441441
expect(whiteSpy).not.toHaveBeenCalled();
442-
expect(blackSpy).toHaveBeenCalledWith('test_fail');
442+
expect(blackSpy).toHaveBeenCalledWith(new Error('test_fail'));
443443
});
444444

445445
it('should modify data in firebase', function() {

0 commit comments

Comments
 (0)