Allow services created with $extend to be called without the new keyword.

Author: katowulf

src/FirebaseArray.js

@@ -576,7 +576,13 @@
       FirebaseArray.$extend = function(ChildClass, methods) {
         if( arguments.length === 1 && angular.isObject(ChildClass) ) {
           methods = ChildClass;
-          ChildClass = function() { return FirebaseArray.apply(this, arguments); };
+          ChildClass = function(ref) {
+            if( !(this instanceof ChildClass) ) {
+              return new ChildClass(ref);
+            }
+            FirebaseArray.apply(this, arguments);
+            return this.$list;
+          };
         }
         return $firebaseUtils.inherit(ChildClass, FirebaseArray, methods);
       };

src/FirebaseObject.js

@@ -287,7 +287,12 @@
       FirebaseObject.$extend = function(ChildClass, methods) {
         if( arguments.length === 1 && angular.isObject(ChildClass) ) {
           methods = ChildClass;
-          ChildClass = function() { FirebaseObject.apply(this, arguments); };
+          ChildClass = function(ref) {
+            if( !(this instanceof ChildClass) ) {
+              return new ChildClass(ref);
+            }
+            FirebaseObject.apply(this, arguments);
+          };
         }
         return $firebaseUtils.inherit(ChildClass, FirebaseObject, methods);
       };

tests/mocks/mock.utils.js

@@ -783,7 +783,7 @@ describe('$firebaseArray', function () {
   describe('$extend', function() {
     it('should return a valid array', function() {
       var F = $firebaseArray.$extend({});
-      expect(Array.isArray(new F(stubRef()))).toBe(true);
+      expect(Array.isArray(F(stubRef()))).toBe(true);
     });
 
     it('should preserve child prototype', function() {
@@ -809,11 +809,23 @@ describe('$firebaseArray', function () {
     it('should add on methods passed into function', function() {
       function foo() { return 'foo'; }
       var F = $firebaseArray.$extend({foo: foo});
-      var res = new F(stubRef());
+      var res = F(stubRef());
       expect(typeof res.$$updated).toBe('function');
       expect(typeof res.foo).toBe('function');
       expect(res.foo()).toBe('foo');
     });
+
+    it('should work with the new keyword', function() {
+      var fn = function() {};
+      var Res = $firebaseArray.$extend({foo: fn});
+      expect(new Res(stubRef()).foo).toBeA('function');
+    });
+
+    it('should work without the new keyword', function() {
+      var fn = function() {};
+      var Res = $firebaseArray.$extend({foo: fn});
+      expect(Res(stubRef()).foo).toBeA('function');
+    });
   });
 
   var flushAll = (function() {

tests/unit/FirebaseArray.spec.js

@@ -587,11 +587,24 @@ describe('$firebaseObject', function() {
         return 'foo';
       }
       var F = $firebaseObject.$extend({foo: foo});
-      var res = new F(stubRef());
+      var res = F(stubRef());
       expect(res.$$updated).toBeA('function');
       expect(res.foo).toBeA('function');
       expect(res.foo()).toBe('foo');
     });
+
+
+    it('should work with the new keyword', function() {
+      var fn = function() {};
+      var Res = $firebaseObject.$extend({foo: fn});
+      expect(new Res(stubRef()).foo).toBeA('function');
+    });
+
+    it('should work without the new keyword', function() {
+      var fn = function() {};
+      var Res = $firebaseObject.$extend({foo: fn});
+      expect(Res(stubRef()).foo).toBeA('function');
+    });
   });
 
   describe('$$updated', function () {

tests/unit/FirebaseObject.spec.js

@@ -1,13 +1,8 @@
 'use strict';
 describe('$firebase', function () {
 
-  var $firebase, $timeout, $rootScope, $utils;
-
-  var defaults = JSON.parse(window.__html__['fixtures/data.json']);
-
   beforeEach(function () {
     module('firebase');
-    module('mock.utils');
   });
 
   describe('<constructor>', function () {