Merge pull request #513 from firebase/fix510-deux

Fixes #510 - call onAuth() listeners in $digest scope

Author: Jacob Wenger

src/FirebaseAuth.js

@@ -195,11 +195,12 @@
     onAuth: function(callback, context) {
       var self = this;
 
-      this._ref.onAuth(callback, context);
+      var fn = this._utils.debounce(callback, context, 0);
+      this._ref.onAuth(fn);
 
       // Return a method to detach the `onAuth()` callback.
       return function() {
-        self._ref.offAuth(callback, context);
+        self._ref.offAuth(fn);
       };
     },
 

tests/unit/FirebaseAuth.spec.js

@@ -270,19 +270,21 @@ describe('FirebaseAuth',function(){
   });
 
   describe('$onAuth()',function(){
-    it('calls onAuth() on the backing ref with callback and context provided',function(){
-      function cb(){}
+    //todo add more testing here after mockfirebase v2 auth is released
+
+    it('calls onAuth() on the backing ref', function() {
+      function cb() {}
       var ctx = {};
-      auth.$onAuth(cb,ctx);
-      expect(ref.onAuth).toHaveBeenCalledWith(cb, ctx);
+      auth.$onAuth(cb, ctx);
+      expect(ref.onAuth).toHaveBeenCalledWith(jasmine.any(Function));
     });
 
-    it('returns a deregistration function that calls offAuth() on the backing ref with callback and context',function(){
-      function cb(){}
+    it('returns a deregistration function that calls offAuth() on the backing ref', function(){
+      function cb() {}
       var ctx = {};
-      var deregister = auth.$onAuth(cb,ctx);
+      var deregister = auth.$onAuth(cb, ctx);
       deregister();
-      expect(ref.offAuth).toHaveBeenCalledWith(cb, ctx);
+      expect(ref.offAuth).toHaveBeenCalledWith(jasmine.any(Function));
     });
   });