Merge pull request #549 from firebase/jw-error-on-array

Added error message when trying to use array-like data stored in Firebase

Author: katowulf

src/FirebaseArray.js

@@ -210,6 +210,8 @@
         $loaded: function(resolve, reject) {
           var promise = this._promise;
           if( arguments.length ) {
+            // allow this method to be called just like .then
+            // by passing any arguments on to .then
             promise = promise.then.call(promise, resolve, reject);
           }
           return promise;

src/firebase.js

@@ -9,8 +9,8 @@
     //
     //   * `ref`: A Firebase reference. Queries or limits may be applied.
     //   * `config`: An object containing any of the advanced config options explained in API docs
-    .factory("$firebase", [ "$firebaseUtils", "$firebaseConfig",
-      function ($firebaseUtils, $firebaseConfig) {
+    .factory("$firebase", [ "$log", "$firebaseUtils", "$firebaseConfig",
+      function ($log, $firebaseUtils, $firebaseConfig) {
         function AngularFire(ref, config) {
           // make the new keyword optional
           if (!(this instanceof AngularFire)) {
@@ -202,7 +202,13 @@
             ref.on('child_removed', removed, error);
 
             // determine when initial load is completed
-            ref.once('value', function() { resolve(null); }, resolve);
+            ref.once('value', function(snap) {
+              if (angular.isArray(snap.val())) {
+                $log.warn('Storing data using array indices in Firebase can result in unexpected behavior. See https://www.firebase.com/docs/web/guide/understanding-data.html#section-arrays-in-firebase for more information.');
+              }
+
+              resolve(null);
+            }, resolve);
           }
 
           // call resolve(), do not call this directly
@@ -281,7 +287,13 @@
 
           function init() {
             ref.on('value', applyUpdate, error);
-            ref.once('value', function() { resolve(null); }, resolve);
+            ref.once('value', function(snap) {
+              if (angular.isArray(snap.val())) {
+                $log.warn('Storing data using array indices in Firebase can result in unexpected behavior. See https://www.firebase.com/docs/web/guide/understanding-data.html#section-arrays-in-firebase for more information.');
+              }
+
+              resolve(null);
+            }, resolve);
           }
 
           // call resolve(); do not call this directly