Merge pull request #596 from jamestalmage/added-returns-a-promise

Proposal: Allow extenders of firebaseArray.$$added to return promises.

Author: katowulf

src/FirebaseArray.js

@@ -634,7 +634,11 @@
         var created = $firebaseUtils.batch(function(snap, prevChild) {
           var rec = firebaseArray.$$added(snap, prevChild);
           if( rec ) {
-            firebaseArray.$$process('child_added', rec, prevChild);
+            $firebaseUtils.resolve(rec).then(function(rec) {
+              if( rec ) {
+                firebaseArray.$$process('child_added', rec, prevChild);
+              }
+            });
           }
         });
         var updated = $firebaseUtils.batch(function(snap) {

tests/unit/FirebaseArray.spec.js

@@ -83,6 +83,30 @@ describe('$firebaseArray', function () {
       expect(spy).toHaveBeenCalledWith(arr.$ref().child(lastId));
     });
 
+    it('should wait for promise resolution to update array', function () {
+      var queue = [];
+      function addPromise(snap, prevChild){
+        return new $utils.promise(
+          function(resolve) {
+            queue.push(resolve);
+          }).then(function(name) {
+            var data = $firebaseArray.prototype.$$added.call(arr, snap, prevChild);
+            data.name = name;
+            return data;
+          });
+      }
+      arr = stubArray(null, $firebaseArray.$extend({$$added:addPromise}));
+      expect(arr.length).toBe(0);
+      arr.$add({userId:'1234'});
+      flushAll(arr.$ref());
+      expect(arr.length).toBe(0);
+      expect(queue.length).toBe(1);
+      queue[0]('James');
+      $timeout.flush();
+      expect(arr.length).toBe(1);
+      expect(arr[0].name).toBe('James')
+    });
+
     it('should reject promise on fail', function() {
       var successSpy = jasmine.createSpy('resolve spy');
       var errSpy = jasmine.createSpy('reject spy');