Updated from Kato's feedback

Author: jacobawenger

src/FirebaseArray.js

@@ -256,14 +256,14 @@
          */
         $$added: function(snap, prevChild) {
           // check to make sure record does not exist
-          var i = this.$indexFor(this._getSnapshotKey(snap));
+          var i = this.$indexFor($firebaseUtils.getSnapshotKey(snap));
           if( i === -1 ) {
             // parse data and create record
             var rec = snap.val();
             if( !angular.isObject(rec) ) {
               rec = { $value: rec };
             }
-            rec.$id = this._getSnapshotKey(snap);
+            rec.$id = $firebaseUtils.getSnapshotKey(snap);
             rec.$priority = snap.getPriority();
             $firebaseUtils.applyDefaults(rec, this.$$defaults);
 
@@ -279,7 +279,7 @@
          * @param snap
          */
         $$removed: function(snap) {
-          var rec = this.$getRecord(this._getSnapshotKey(snap));
+          var rec = this.$getRecord($firebaseUtils.getSnapshotKey(snap));
           if( angular.isObject(rec) ) {
             this._process('child_removed', rec);
           }
@@ -292,7 +292,7 @@
          * @param snap
          */
         $$updated: function(snap) {
-          var rec = this.$getRecord(this._getSnapshotKey(snap));
+          var rec = this.$getRecord($firebaseUtils.getSnapshotKey(snap));
           if( angular.isObject(rec) ) {
             // apply changes to the record
             var changed = $firebaseUtils.updateRec(rec, snap);
@@ -311,7 +311,7 @@
          * @param {string} prevChild
          */
         $$moved: function(snap, prevChild) {
-          var rec = this.$getRecord(this._getSnapshotKey(snap));
+          var rec = this.$getRecord($firebaseUtils.getSnapshotKey(snap));
           if( angular.isObject(rec) ) {
             rec.$priority = snap.getPriority();
             this._process('child_moved', rec, prevChild);
@@ -469,10 +469,6 @@
           if( this._isDestroyed ) {
             throw new Error('Cannot call ' + method + ' method on a destroyed $FirebaseArray object');
           }
-        },
-
-        _getSnapshotKey: function(snapshot) {
-          return (typeof snapshot.key === 'function') ? snapshot.key() : snapshot.name();
         }
       };
 

src/FirebaseObject.js

@@ -55,7 +55,7 @@
           value: this.$$conf
         });
 
-        this.$id = this._getSnapshotKey($firebase.$ref().ref());
+        this.$id = $firebaseUtils.getSnapshotKey($firebase.$ref().ref());
         this.$priority = null;
 
         $firebaseUtils.applyDefaults(this, this.$$defaults);
@@ -227,10 +227,6 @@
          */
         forEach: function(iterator, context) {
           return $firebaseUtils.each(this, iterator, context);
-        },
-
-        _getSnapshotKey: function(snapshot) {
-          return (typeof snapshot.key === 'function') ? snapshot.key() : snapshot.name();
         }
       };
 

src/firebase.js

@@ -42,7 +42,6 @@
           },
 
           $set: function (key, data) {
-            var self = this;
             var ref = this._ref;
             var def = $firebaseUtils.defer();
             if (arguments.length > 1) {
@@ -62,8 +61,8 @@
               // the entire Firebase path
               ref.once('value', function(snap) {
                 snap.forEach(function(ss) {
-                  if( !dataCopy.hasOwnProperty(self._getSnapshotKey(ss)) ) {
-                    dataCopy[self._getSnapshotKey(ss)] = null;
+                  if( !dataCopy.hasOwnProperty($firebaseUtils.getSnapshotKey(ss)) ) {
+                    dataCopy[$firebaseUtils.getSnapshotKey(ss)] = null;
                   }
                 });
                 ref.ref().update(dataCopy, this._handle(def, ref));
@@ -173,10 +172,6 @@
             if (!angular.isFunction(cnf.objectFactory)) {
               throw new Error('config.objectFactory must be a valid function');
             }
-          },
-
-          _getSnapshotKey: function(snapshot) {
-            return (typeof snapshot.key === 'function') ? snapshot.key() : snapshot.name();
           }
         };
 

src/utils.js

@@ -341,6 +341,16 @@
             return obj;
           },
 
+          /**
+           * A utility for retrieving a DataSnapshot's key name. This
+           * is backwards-compatible with .name() from Firebase 1.x.x
+           * and .key() from Firebase 2.0.0+. Once support for Firebase
+           * 1.x.x is dropped in AngularFire, this helper can be removed.
+           */
+          getSnapshotKey: function(snapshot) {
+            return (typeof snapshot.key === 'function') ? snapshot.key() : snapshot.name();
+          },
+
           /**
            * A utility for converting records to JSON objects
            * which we can save into Firebase. It asserts valid
@@ -401,4 +411,4 @@
       });
       return out;
     }
-})();
+})();

tests/unit/utils.spec.js

@@ -174,4 +174,12 @@ describe('$firebaseUtils', function () {
     });
   });
 
-});
+  describe('#getSnapshotKey', function() {
+    it('should return the key name given a DataSnapshot', function() {
+      var snapshot = testutils.snap('data', 'foo');
+
+      expect($utils.getSnapshotKey(snapshot)).toEqual('foo');
+    });
+  });
+
+});