remove test / mock dead code

Author: kotl

contrib/test/mock-firebase.h

@@ -20,21 +20,6 @@ class MockFirebase : public FirebaseArduino {
   MOCK_CONST_METHOD2(begin, void (const String& host, const String& auth));
 };
 
-
-class MockFirebaseRequest : public FirebaseRequest {
- public:
-  MOCK_CONST_METHOD0(name, const std::string&());
-  MOCK_CONST_METHOD0(response, const std::string&());
-  MOCK_CONST_METHOD0(error, const FirebaseError&());
-};
-
-class MockFirebaseStream : public FirebaseStream {
- public:
-  MOCK_METHOD0(available, bool());
-  MOCK_METHOD1(read, Event(std::string& event));
-  MOCK_CONST_METHOD0(error, const FirebaseError&());
-};
-
 }  // modem
 }  // firebase
 #endif  // TEST_MOCK_FIREBASE_H

contrib/test/modem/get-command_test.cpp

@@ -16,7 +16,6 @@ using ::testing::_;
 class GetCommandTest : public ::testing::Test {
  protected:
   void SetUp() override {
-    get_.reset(new MockFirebaseRequest());
   }
 
   void FeedCommand(const String& path) {
@@ -26,26 +25,20 @@ class GetCommandTest : public ::testing::Test {
   }
 
   bool RunCommand(const FirebaseError& error) {
-    EXPECT_CALL(*get_, error())
-      .WillRepeatedly(ReturnRef(error));
-
     GetCommand getCmd(&fbase_);
     return getCmd.execute("GET", &in_, &out_);
   }
 
   MockInputStream in_;
   MockOutputStream out_;
   MockFirebase fbase_;
-  std::unique_ptr<MockFirebaseRequest> get_;
 };
 
 TEST_F(GetCommandTest, gets) {
   const String path("/test/path");
   FeedCommand(path);
 
   const String value("Test value");
-  EXPECT_CALL(*get_, response())
-      .WillOnce(ReturnRef(value));
 
   EXPECT_CALL(out_, print(String("+")))
       .WillOnce(Return(1));

contrib/test/modem/push-command_test.cpp

@@ -17,7 +17,6 @@ using ::testing::_;
 class PushCommandTest : public ::testing::Test {
  protected:
   void SetUp() override {
-    push_.reset(new MockFirebaseRequest());
   }
 
   void FeedCommand(const String& path, const String& data) {
@@ -41,20 +40,13 @@ class PushCommandTest : public ::testing::Test {
   }
 
   bool RunExpectingData(const String& data, const FirebaseError& error) {
-    EXPECT_CALL(*push_, error())
-      .WillRepeatedly(ReturnRef(error));
-
-    EXPECT_CALL(fbase_, pushPtr(_, EncodeForJson(data)))
-        .WillOnce(Return(ByMove(std::move(push_))));
-
     PushCommand pushCmd(&fbase_);
     return pushCmd.execute("PUSH", &in_, &out_);
   }
 
   MockInputStream in_;
   MockOutputStream out_;
   MockFirebase fbase_;
-  std::unique_ptr<MockFirebaseRequest> push_;
 };
 
 TEST_F(PushCommandTest, sendsData) {

contrib/test/modem/remove-command_test.cpp

@@ -16,7 +16,6 @@ using ::testing::_;
 class RemoveCommandTest : public ::testing::Test {
  protected:
   void SetUp() override {
-    remove_.reset(new MockFirebaseRequest());
   }
 
   void FeedCommand(const String& path) {
@@ -26,11 +25,6 @@ class RemoveCommandTest : public ::testing::Test {
   }
 
   bool RunCommand(const FirebaseError& error) {
-    EXPECT_CALL(*remove_, error())
-      .WillRepeatedly(ReturnRef(error));
-
-    EXPECT_CALL(fbase_, removePtr(_))
-        .WillOnce(Return(ByMove(std::move(remove_))));
 
     RemoveCommand command(&fbase_);
     return command.execute("REMOVE", &in_, &out_);
@@ -39,7 +33,6 @@ class RemoveCommandTest : public ::testing::Test {
   MockInputStream in_;
   MockOutputStream out_;
   MockFirebase fbase_;
-  std::unique_ptr<MockFirebaseRequest> remove_;
 };
 
 TEST_F(RemoveCommandTest, success) {

contrib/test/modem/set-command_test.cpp

@@ -17,7 +17,6 @@ using ::testing::_;
 class SetCommandTest : public ::testing::Test {
  protected:
   void SetUp() override {
-    set_.reset(new MockFirebaseRequest());
   }
 
   void FeedCommand(const String& path, const String& data) {
@@ -41,11 +40,6 @@ class SetCommandTest : public ::testing::Test {
   }
 
   bool RunExpectingData(const String& data, const FirebaseError& error) {
-    EXPECT_CALL(*set_, error())
-      .WillRepeatedly(ReturnRef(error));
-
-    EXPECT_CALL(fbase_, setPtr(_, EncodeForJson(data)))
-        .WillOnce(Return(ByMove(std::move(set_))));
 
     SetCommand setCmd(&fbase_);
     return setCmd.execute("SET", &in_, &out_);
@@ -54,7 +48,6 @@ class SetCommandTest : public ::testing::Test {
   MockInputStream in_;
   MockOutputStream out_;
   MockFirebase fbase_;
-  std::unique_ptr<MockFirebaseRequest> set_;
 };
 
 TEST_F(SetCommandTest, sendsData) {