Skip to content

Commit c240586

Browse files
authored
Match framework version with buildpack changes (#228)
* Match adapter with buildpack changes Change env var representing framework version all to "FRAMEWORK_VERSION"; and buildtime availability to "BUILD" * fix enum * fix
1 parent 3b0b5c0 commit c240586

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

packages/@apphosting/adapter-angular/src/bin/build.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,6 @@ if (!output) {
2020
throw new Error("No output from Angular build command, expecting a build manifest file.");
2121
}
2222
const outputBundleOptions = parseOutputBundleOptions(output);
23-
await generateOutputDirectory(root, outputBundleOptions, process.env.ANGULAR_VERSION);
23+
await generateOutputDirectory(root, outputBundleOptions, process.env.FRAMEWORK_VERSION);
2424

2525
await validateOutputDirectory(outputBundleOptions);

packages/@apphosting/adapter-angular/src/interface.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,13 @@ export interface OutputBundleOptions {
1616
export interface EnvironmentVariable {
1717
variable: string;
1818
value: string;
19-
availability: Availability.RUNTIME; // currently support RUNTIME only
19+
availability: Availability.Runtime; // currently support RUNTIME only
2020
}
2121

2222
// defines whether the environment variable is buildtime, runtime or both
2323
export enum Availability {
24-
BUILDTIME = "BUILDTIME",
25-
RUNTIME = "RUNTIME",
24+
Buildtime = "BUILD",
25+
Runtime = "RUNTIME",
2626
}
2727

2828
// valid manifest schema

packages/@apphosting/adapter-angular/src/utils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ function addBundleYamlEnvVar(angularVersion?: string): EnvironmentVariable[] {
168168
const ssrPortEnvVar: EnvironmentVariable = {
169169
variable: "SSR_PORT",
170170
value: "8080",
171-
availability: Availability.RUNTIME,
171+
availability: Availability.Runtime,
172172
};
173173
runtimeEnvVars.push(ssrPortEnvVar);
174174
}

0 commit comments

Comments
 (0)