test

Author: annajowang

packages/@apphosting/adapter-angular/package.json

@@ -23,7 +23,7 @@
   "scripts": {
     "build": "rm -rf dist && tsc && chmod +x ./dist/bin/*",
     "test": "npm run test:unit && npm run test:functional",
-    "test:unit": "ts-mocha -p tsconfig.json src/**/*.spec.ts",
+    "test:unit": "ts-mocha -p tsconfig.json 'src/**/*.spec.ts' 'src/*.spec.ts'",
     "test:functional": "node --loader ts-node/esm ./e2e/run-local.ts",
     "localregistry:start": "npx verdaccio --config ../publish-dev/verdaccio-config.yaml",
     "localregistry:publish": "(npm view --registry=http://localhost:4873 @apphosting/adapter-angular && npm unpublish --@apphosting:registry=http://localhost:4873 --force); npm publish --@apphosting:registry=http://localhost:4873"

packages/@apphosting/adapter-angular/src/bin/build.spec.ts

@@ -83,6 +83,7 @@ metadata:
     const expectedOutputBundleOptions = {
       browserDirectory: "/browser",
       bundleYamlPath: resolve(".apphosting", "bundle.yaml"),
+      outputDirectoryBasePath: resolve(".apphosting"),
       needsServerGenerated: false,
       serverFilePath: path.join("/server", "server.mjs"),
     };

packages/@apphosting/adapter-angular/src/utils.spec.ts

@@ -0,0 +1,68 @@
+const importUtils = import("@apphosting/adapter-angular/dist/utils.js");
+import assert from "assert";
+import fs from "fs";
+import { resolve } from "path";
+import path from "path";
+import { stringify as yamlStringify } from "yaml";
+import os from "os";
+
+const { metaFrameworkOutputBundleExists } = await importUtils;
+
+function generateTmpDir(): string {
+  return fs.mkdtempSync(path.join(os.tmpdir(), "test-files"));
+}
+
+describe("metaFrameworkOutputBundleExists", () => {
+  let bundlePath: string;
+  const originalCwd = process.cwd.bind(process);
+
+  beforeEach(() => {
+    const tmpDir = generateTmpDir();
+    process.cwd = () => tmpDir;
+    fs.mkdirSync(resolve(tmpDir, ".apphosting"));
+    bundlePath = resolve(tmpDir, ".apphosting", "bundle.yaml");
+  });
+
+  afterEach(() => {
+    process.cwd = originalCwd;
+  });
+
+  it("unrecogznied bundle", async () => {
+    const content = "chicken: bok bok";
+    fs.writeFileSync(bundlePath, yamlStringify(content));
+    assert(!metaFrameworkOutputBundleExists());
+  });
+
+  it("no bundle exists", async () => {
+    assert(!metaFrameworkOutputBundleExists());
+  });
+
+  it("meta-framework bundle exists", async () => {
+    const outputBundle: OutputBundleConfig = {
+      version: "v1",
+      runConfig: {
+        runCommand: `does not matter`,
+      },
+      metadata: {
+        framework: "nitro",
+      },
+    };
+    fs.writeFileSync(bundlePath, yamlStringify(outputBundle));
+    assert(metaFrameworkOutputBundleExists());
+  });
+
+  it("angular bundle exists", async () => {
+    const outputBundle: OutputBundleConfig = {
+      version: "v1",
+
+      runConfig: {
+        runCommand: `does not matter`,
+      },
+      metadata: {
+        framework: "angular",
+      },
+    };
+    fs.writeFileSync(bundlePath, yamlStringify(outputBundle));
+    assert(!metaFrameworkOutputBundleExists());
+  });
+});

packages/@apphosting/adapter-angular/src/utils.ts

@@ -283,8 +283,8 @@ export const metaFrameworkOutputBundleExists = () => {
   const bundleYamlPath = join(outputBundleDir, "bundle.yaml");
   if (existsSync(bundleYamlPath)) {
     try {
-      const bundle: OutputBundleConfig = parseYaml(readFileSync(bundleYamlPath, "utf8"));
-      if (bundle.metadata?.framework && bundle.metadata.framework !== "angular") {
+      const bundle = parseYaml(readFileSync(bundleYamlPath, "utf8"));
+      if (bundle?.metadata?.framework && bundle.metadata.framework !== "angular") {
         return true;
       }
     } catch (e) {

packages/@apphosting/adapter-angular/tsconfig.json

@@ -4,7 +4,7 @@
     "noEmit": false,
     "outDir": "dist",
     "rootDir": "src",
-    "allowJs": true
+    //"allowJs": true
   },
   "include": [
     "src/index.ts",