Skip to content

Commit e9e3167

Browse files
authored
Refine and clean the Turbo + Angular JSON manifest output (#380)
This PR strips the angular manifest for a turbo build, and bumps the angular adapter and the common folder versions. With the angular manifest parsing fix and the monorepo args split fix, the angular + turbo will be fixed.
1 parent 210f73b commit e9e3167

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

packages/@apphosting/adapter-angular/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@apphosting/adapter-angular",
3-
"version": "17.2.15",
3+
"version": "17.2.16",
44
"main": "dist/index.js",
55
"description": "Experimental addon to the Firebase CLI to add web framework support",
66
"repository": {

packages/@apphosting/adapter-angular/src/utils.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,10 @@ function extractManifestOutput(output: string): string {
175175
if (start === -1 || end === -1 || start > end) {
176176
throw new Error(`Failed to find valid JSON object from build output: ${output}`);
177177
}
178-
return stripAnsi(output.substring(start, end + 1));
178+
// Clean the raw json string by removing the "web:build:" prefixes for a Turbo build
179+
const prefixRegex = /\n?web:build:/g;
180+
const cleanedOutput = output.substring(start, end + 1).replace(prefixRegex, "");
181+
return stripAnsi(cleanedOutput);
179182
}
180183

181184
/**

packages/@apphosting/common/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@apphosting/common",
3-
"version": "0.0.6",
3+
"version": "0.0.7",
44
"description": "Shared library code for App Hosting framework adapters",
55
"author": {
66
"name": "Firebase",

0 commit comments

Comments
 (0)