fixing the canary build & stuff

Author: jamesdaniels

package-lock.json

@@ -22,7 +22,8 @@
   ],
   "sideEffects": false,
   "scripts": {
-    "build": "rm -rf dist && tsc && ts-node ./tools/build.ts",
+    "build": "rm -rf dist && tsc -p tsconfig.client.json && tsc && ts-node ./tools/build.ts",
+    "dev": "npm run build && ts-node ./tools/dev.ts",
     "test": "echo \"Error: no test specified\" && exit 1",
     "e2e:build-next": "rm -rf e2e && npx create-next-app e2e --use-npm --ts",
     "e2e:build-nuxt": "rm -rf e2e && npx create-nuxt-app e2e --answers '$(cat ./tools/create-nuxt-answers.json)'",
@@ -52,8 +53,7 @@
       "node": "./dist/server/firebase-aware.js",
       "default": null
     },
-    "./client/auth": "./dist/client/auth/index.js",
-    "./client/app": "./dist/client/app/index.js"
+    "./client/auth": "./dist/client/auth/index.js"
   },
   "files": [
     "dist"
@@ -63,7 +63,8 @@
     "fs-extra": "^10.1.0",
     "jsonc-parser": "^3.0.0",
     "semver": "^7.3.7",
-    "tslib": "^2.3.1"
+    "tslib": "^2.3.1",
+    "firebase": "^9.8.1"
   },
   "devDependencies": {
     "@angular-devkit/architect": "^0.1303.3",
@@ -76,7 +77,6 @@
     "@types/node": "^16.11.12",
     "@types/semver": "^7.3.9",
     "cookie": "^0.5.0",
-    "firebase": "^9.8.1",
     "firebase-admin": "^10.1.0",
     "firebase-functions": "^3.20.1",
     "firebase-tools": "^10.5.0",

package.json

@@ -9,7 +9,8 @@ import {
     Dependencies
 } from 'firebase/auth';
 import type { FirebaseApp } from 'firebase/app';
-import { ID_TOKEN_MAX_AGE } from '../../constants';
+
+export const ID_TOKEN_MAX_AGE = 5 * 60;
 
 let alreadySetup = false;
 let lastPostedIdToken: string|undefined|null = null;
@@ -42,12 +43,14 @@ const setup = (auth: Auth) => {
 }
 
 export function getAuth(app?: FirebaseApp) {
+    console.log('yo!');
     const auth = getFirebaseAuth(app);
     setup(auth);
     return auth;
 }
 
 export function initializeAuth(app: FirebaseApp, deps?: Dependencies) {
+    console.log('yo!');
     const auth = initializeFirebaseAuth(app, deps);
     setup(auth);
     return auth;

src/client/auth/index.ts

@@ -1,3 +1,4 @@
+export { ID_TOKEN_MAX_AGE } from './client/auth';
 export const FIREBASE_ADMIN_VERSION = '__FIREBASE_ADMIN_VERSION__';
 export const FIREBASE_FUNCTIONS_VERSION = '__FIREBASE_FUNCTIONS_VERSION__';
 export const COOKIE_VERSION = '__COOKIE_VERSION__';
@@ -6,6 +7,5 @@ export const FIREBASE_FRAMEWORKS_VERSION = '__FIREBASE_FRAMEWORKS_VERSION__';
 export const DEFAULT_REGION = 'us-central1';
 export const LRU_MAX_INSTANCES = 100;
 export const LRU_TTL = 1_000 * 60 * 5;
-export const ID_TOKEN_MAX_AGE = 5 * 60;
 export const COOKIE_MAX_AGE = 60 * 60 * 24 * 5 * 1_000;
 export const MIN_FIREBASE_SDK_FOR_AUTH = '9.8.0';

src/constants.ts

@@ -44,7 +44,8 @@ export const build = async (config: DeployConfig | Required<DeployConfig>, getPr
             webpack: (config, context) => {
                 let newConfig = config;
                 if (nextConfig.webpack) newConfig = nextConfig.webpack(config, context);
-                const plugin = getWebpackPlugin(getProjectPath());
+                if (context.isServer) return newConfig;
+                const plugin = getWebpackPlugin(context.webpack, getProjectPath());
                 newConfig.plugins ||= [];
                 newConfig.plugins.push(plugin);
                 return newConfig;
@@ -61,12 +62,14 @@ export const build = async (config: DeployConfig | Required<DeployConfig>, getPr
 
     await nextBuild(getProjectPath(), overrideConfig as any, false, false, true);
 
+    console.log('Attempting `next export`...');
+
     await nextExport(
         getProjectPath(),
         { silent: true, outdir: getHostingPath() },
         trace('next-export-cli')
     ).catch(() => {
-        console.warn('\nUnable to export the app, treating as SSR.\n\n');
+        console.warn('\nIgnore the above error, Next.js is not respecting the silent flag. Since next export did not succeed we\'ll treat as SSR.\n\n');
     });
 
     let usingCloudFunctions = !!config.function;

src/frameworks/next.js/index.ts

@@ -14,7 +14,6 @@
 
 import { exec as execCallback, spawn as spawnCallback, ExecOptions, SpawnOptionsWithoutStdio, spawnSync } from 'child_process';
 import { dirname, join, relative, resolve, sep } from 'path';
-import { exit } from 'process';
 import { lt } from 'semver';
 import { MIN_FIREBASE_SDK_FOR_AUTH } from './constants';
 
@@ -79,16 +78,9 @@ export const findDependency = (name: string, cwd=process.cwd()) => {
     return search(name, json.dependencies);
 }
 
-export const getWebpackPlugin = (cwd: string) => {
-    let webpack: typeof import('webpack');
-    try {
-        webpack = require('webpack');
-    } catch(e) {
-        console.error('Webpack is required for auth-context awareness in SSR, npm i --save-dev webpack.');
-        exit(1);
-    }
+export const getWebpackPlugin = (webpack: typeof import('webpack'), cwd: string) => {
     const { NormalModuleReplacementPlugin } = webpack;
-    new NormalModuleReplacementPlugin(/^firebase\/(auth)$/, (resource: any) => {
+    return new NormalModuleReplacementPlugin(/^firebase\/(auth)$/, (resource: any) => {
         // Don't allow firebase-frameworks to recurse
         const frameworksRoot = resolve(`${dirname(require.resolve('.'))}${sep}..`);
         if (resource.context.startsWith(frameworksRoot)) return;
@@ -100,6 +92,7 @@ export const getWebpackPlugin = (cwd: string) => {
         if (client === 'auth' && lt(firebaseDependency.version, MIN_FIREBASE_SDK_FOR_AUTH)) return;
         // TODO log to the firebase.log
         console.log(`Substituting import of '${resource.request}' with 'firebase-frameworks/client/${client}' in ${relative(cwd, resource.context)}.`);
-        resource.request = require.resolve(`./client/${client}`);
+        console.log(require.resolve(`firebase-frameworks/client/${client}`));
+        resource.request = require.resolve(`firebase-frameworks/client/${client}`);
     })
 };

src/utils.ts

@@ -12,7 +12,6 @@ const LOCAL_NODE_MODULES = [
     'nuxt',
     '@nuxt/kit/dist/index.mjs',
     'webpack',
-    'firebase/auth',
 ];
 
 const ES_MODULES = [

tools/build.ts

@@ -0,0 +1,23 @@
+import { exit } from 'process';
+import { replaceInFile } from 'replace-in-file';
+import { join } from 'path';
+import { readJson } from 'fs-extra';
+import { exec } from '../src/utils';
+
+const run = async () => {
+    const { name, version } = await readJson('./package.json');
+    const path = join(process.cwd(), `${name}-${version}.tgz`);
+    await replaceInFile({
+        files: 'dist/constants.js',
+        from: /^exports\.FIREBASE_FRAMEWORKS_VERSION = .*$/gm,
+        to: `exports.FIREBASE_FRAMEWORKS_VERSION = 'file:${path}';`,
+    });
+    await exec('npm pack .');
+    const npmRoot = await exec('npm root');
+    await exec(`npm install --force --ignore-scripts --save ${path}`, { cwd: join(npmRoot as string, 'firebase-tools') });
+}
+
+run().then(
+    () => exit(0),
+    () => exit(1)
+);

tools/dev.ts

@@ -0,0 +1,16 @@
+{
+    "compilerOptions": {
+      "outDir": "dist/client/auth",
+      "target": "esnext",
+      "module": "esnext",
+      "moduleResolution": "node",
+      "forceConsistentCasingInFileNames": true,
+      "strict": true,
+      "declaration": true,
+      "skipLibCheck": true
+    },
+    "include": [
+      "src/client/auth/index.ts",
+    ]
+  }
+  

tsconfig.client.json

@@ -16,10 +16,9 @@
   "include": [
     "src/index.ts",
     "src/tools.ts",
-    "src/client/*/index.ts",
     "src/server/index.ts",
     "src/server/firebase-aware.ts",
     "src/frameworks/*/server.ts",
-    "types/*.d.ts", "src/client/auth/index.js",
+    "types/*.d.ts"
   ]
 }