Nextjs use spec #253
Merged
Nextjs use spec #253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yuangwang
requested review from
blidd-google,
jamesdaniels,
sjjj986,
taeold and
tonyjhuang
as code owners
sjjj986
reviewed
Sep 17, 2024
sjjj986
reviewed
Sep 17, 2024
| await mkdir(opts.outputDirectoryBasePath); | ||
| const outputBundle: OutputBundleConfig = { | ||
| version: "v1", | ||
| serverConfig: { |
Collaborator
There was a problem hiding this comment.
How will the env var section be taken cared of here?
Collaborator
Author
There was a problem hiding this comment.
It will be done the same way things are done in the angular adapter, we'll only add it if needed. For now we don't have any env var needs and env var is optional so there is no need to add a field for it yet
tonyjhuang
approved these changes
Sep 26, 2024
| const pathsToMove = await readdir(appDir); | ||
| for (const path of pathsToMove) { | ||
| const isOutputBundleDir = join(appDir, path) === outputBundleAppDir; | ||
| const isbundleYamlDir = join(appDir, path) === dirname(bundleYamlPath); |
| async function generateBundleYaml( | ||
| outputBundleOptions: OutputBundleOptions, | ||
| nextBuildDirectory: string, | ||
| opts: OutputBundleOptions, |
Collaborator
There was a problem hiding this comment.
optional nit: you can unpack this if you prefer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new output bundle spec for nextjs.
Also copies assets into standalone directory instead of .apphosting