Custom App Hosting Headers for NextJS #304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om-apphosting-headers
mathu97
requested review from
Yuangwang,
blidd-google,
jamesdaniels,
leoortizz,
sjjj986,
taeold and
tonyjhuang
as code owners
annajowang
reviewed
Feb 25, 2025
Yuangwang
reviewed
Feb 25, 2025
| key: "x-fah-adapter", | ||
| value: `nextjs-${adapterMetadata.adapterVersion}`, | ||
| }, | ||
| ...(middlewareExists(middlewareManifest) |
There was a problem hiding this comment.
Shouldn't we be adding a separate x-fah-middleware header entry for each of the middleware matchers?
There was a problem hiding this comment.
I think that's what we eventually want to do. I believe we agreed for now that we'll add this header if there is a middleware at all.
Yuangwang
approved these changes
Feb 26, 2025
jamesdaniels
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update NextJS Adapter to:
x-fah-adapterheader that indicates adapter name + versionroute-manifest.jsonfile in the standalone folder to addx-fah-adapterheader.x-fah-middlewareheader for apps that have a middleware.middleware-manifest.jsonfile to check if there are any middlewares used by the app, and updates theroute-manifest.jsonfile to addx-fah-middlewareheader.Manual Testing:
Depends on #305