diff --git a/package-lock.json b/package-lock.json index 53d21361..d6c65b4b 100644 --- a/package-lock.json +++ b/package-lock.json @@ -25520,7 +25520,7 @@ } }, "packages/@apphosting/adapter-angular": { - "version": "17.2.14", + "version": "17.2.15", "license": "Apache-2.0", "dependencies": { "@apphosting/common": "*", @@ -25618,7 +25618,7 @@ } }, "packages/@apphosting/adapter-nextjs": { - "version": "14.0.13", + "version": "14.0.14", "license": "Apache-2.0", "dependencies": { "@apphosting/common": "*", @@ -25728,7 +25728,7 @@ "license": "Apache-2.0" }, "packages/@apphosting/create": { - "version": "0.3.1", + "version": "0.4.0", "license": "Apache-2.0", "dependencies": { "@inquirer/prompts": "^5.0.2", diff --git a/packages/@apphosting/adapter-angular/package.json b/packages/@apphosting/adapter-angular/package.json index 35b64c77..65ed96ba 100644 --- a/packages/@apphosting/adapter-angular/package.json +++ b/packages/@apphosting/adapter-angular/package.json @@ -1,6 +1,6 @@ { "name": "@apphosting/adapter-angular", - "version": "17.2.14", + "version": "17.2.15", "main": "dist/index.js", "description": "Experimental addon to the Firebase CLI to add web framework support", "repository": { diff --git a/packages/@apphosting/adapter-angular/src/bin/build.ts b/packages/@apphosting/adapter-angular/src/bin/build.ts index 5ea5c803..1a7b756e 100644 --- a/packages/@apphosting/adapter-angular/src/bin/build.ts +++ b/packages/@apphosting/adapter-angular/src/bin/build.ts @@ -12,9 +12,6 @@ const opts = getBuildOptions(); // Check build conditions, which vary depending on your project structure (standalone or monorepo) await checkBuildConditions(opts); -if (!process.env.FRAMEWORK_VERSION) { - throw new Error("Could not find the angular version of the application"); -} // enable JSON build logs for application builder process.env.NG_BUILD_LOGS_JSON = "1"; @@ -22,10 +19,12 @@ const { stdout: output } = await runBuild(); if (!output) { throw new Error("No output from Angular build command, expecting a build manifest file."); } + +const angularVersion = process.env.FRAMEWORK_VERSION || "unspecified"; if (!outputBundleExists()) { const outputBundleOptions = parseOutputBundleOptions(output); const root = process.cwd(); - await generateBuildOutput(root, outputBundleOptions, process.env.FRAMEWORK_VERSION); + await generateBuildOutput(root, outputBundleOptions, angularVersion); await validateOutputDirectory(outputBundleOptions); } diff --git a/packages/@apphosting/adapter-nextjs/package.json b/packages/@apphosting/adapter-nextjs/package.json index 0780a261..4e387ea5 100644 --- a/packages/@apphosting/adapter-nextjs/package.json +++ b/packages/@apphosting/adapter-nextjs/package.json @@ -1,6 +1,6 @@ { "name": "@apphosting/adapter-nextjs", - "version": "14.0.13", + "version": "14.0.14", "main": "dist/index.js", "description": "Experimental addon to the Firebase CLI to add web framework support", "repository": { diff --git a/packages/@apphosting/adapter-nextjs/src/bin/build.ts b/packages/@apphosting/adapter-nextjs/src/bin/build.ts index eedb6bbb..f1cc826c 100644 --- a/packages/@apphosting/adapter-nextjs/src/bin/build.ts +++ b/packages/@apphosting/adapter-nextjs/src/bin/build.ts @@ -18,9 +18,6 @@ const opts = getBuildOptions(); process.env.NEXT_PRIVATE_STANDALONE = "true"; // Opt-out sending telemetry to Vercel process.env.NEXT_TELEMETRY_DISABLED = "1"; -if (!process.env.FRAMEWORK_VERSION) { - throw new Error("Could not find the nextjs version of the application"); -} const originalConfig = await loadConfig(root, opts.projectDirectory); @@ -57,12 +54,13 @@ await addRouteOverrides( adapterMetadata, ); +const nextjsVersion = process.env.FRAMEWORK_VERSION || "unspecified"; await generateBuildOutput( root, opts.projectDirectory, outputBundleOptions, nextBuildDirectory, - process.env.FRAMEWORK_VERSION, + nextjsVersion, adapterMetadata, ); await validateOutputDirectory(outputBundleOptions, nextBuildDirectory);