Skip to content

Try catch potential errors when parsing angular build output manifest. #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 28, 2025
Merged

Try catch potential errors when parsing angular build output manifest. #415

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
28c5147
Update @apphosting/common package version.
annajowang Sep 26, 2025
3a3bfb1
Try catch potential errors when parsing angular build output manifest.
annajowang Oct 28, 2025
9f0ab86
Merge branch 'main' into new-common
annajowang Oct 28, 2025
082a150
lint
annajowang Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@apphosting/adapter-angular/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@apphosting/adapter-angular",
"version": "17.2.16",
"version": "17.2.17",
"main": "dist/index.js",
"description": "Experimental addon to the Firebase CLI to add web framework support",
"repository": {
Expand Down
9 changes: 8 additions & 1 deletion packages/@apphosting/adapter-angular/src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,14 @@
export function parseOutputBundleOptions(buildOutput: string): OutputBundleOptions {
const strippedManifest = extractManifestOutput(buildOutput);
// TODO: add functional tests that test this flow
const parsedManifest = JSON.parse(strippedManifest.replace(/[\r\n]+/g, "")) as string;
let parsedManifest;
try {
parsedManifest = JSON.parse(strippedManifest.replace(/[\r\n]+/g, "")) as string;
} catch (error) {
throw new Error(

Check failure on line 155 in packages/@apphosting/adapter-angular/src/utils.ts

View workflow job for this annotation

GitHub Actions / Lint 

Replace `⏎······`Failed·to·parse·build·output·manifest:·${error}`,⏎····` with ``Failed·to·parse·build·output·manifest:·${error}``
`Failed to parse build output manifest: ${error}`,
);
}
const manifest = buildManifestSchema.parse(parsedManifest);
if (manifest["errors"].length > 0) {
// errors when extracting manifest
Expand Down
Loading