Skip to content

Commit 4dd23c6

Browse files
committed
fixes for playwright browser tests
1 parent db6d2b2 commit 4dd23c6

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

src/components/app_tests/firestore/csr_test_runner.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
'use client'
1818

1919
import { useState, useEffect } from 'react'
20-
import { deleteApp, initializeApp } from 'firebase/app';
20+
import { initializeApp } from 'firebase/app';
2121
import { testFirestore, initializeTestResults, SerializedFirestoreData, TestResults } from '@/lib/app_tests/firestore/test';
2222
import ResultsDisplay from './results_display';
2323
import {
@@ -67,7 +67,6 @@ async function runDeserializationTests(
6767
(docSnapshot: DocumentSnapshot
6868
) => {
6969
if (docSnapshot.exists()) {
70-
const docData = docSnapshot.data();
7170
if (validateDocumentData(docSnapshot.data())) {
7271
unsubscribe();
7372
testResults.clientSideDocumentSnapshotOnResumeResult = OK;

src/components/app_tests/firestore/results_display.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export default function ResultsDisplay({ statusString, testResults }) {
2727
<h4 title="updateDocResult">updateDocResult: {testResults.updateDocResult}</h4>
2828
<h4 title="onSnapshotUpdateDR">onSnapshotUpdateDocResult: {testResults.onSnapshotUpdateDocResult}</h4>
2929
<h4 title="getDocResult">getDocResult: {testResults.getDocResult}</h4>
30-
<h4 title="querySnapshotResult">querySnapshotResult: {testResults.querySnapshotResult}</h4>
30+
<h4 title="querySnapshotGetDocsResult">querySnapshotGetDocsResult: {testResults.querySnapshotGetDocsResult}</h4>
3131
<h4 title="documentSnapshotBundleResult">documentSnapshotBundleResult: {testResults.documentSnapshotBundleResult}</h4>
3232
<h4 title="reconstitutedDocDataResult">reconstitutedDocDataResult: {testResults.reconstitutedDocDataResult}</h4>
3333
<h4 title="documentSnapshotOnSnapshotResumeResult">documentSnapshotOnSnapshotResumeResult: {testResults.documentSnapshotOnSnapshotResumeResult}</h4>

src/lib/app_tests/firestore/test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ export type TestResults = {
4646
updateDocResult: string,
4747
onSnapshotUpdateDocResult: string,
4848
getDocResult: string,
49-
querySnapshotResult: string,
49+
querySnapshotGetDocsResult: string,
5050
documentSnapshotBundleResult: string,
5151
reconstitutedDocDataResult: string,
5252
querySnapshotBundleResult: string,
@@ -75,7 +75,7 @@ export function initializeTestResults(): TestResults {
7575
updateDocResult: FAILED,
7676
onSnapshotUpdateDocResult: FAILED,
7777
getDocResult: FAILED,
78-
querySnapshotResult: FAILED,
78+
querySnapshotGetDocsResult: FAILED,
7979
documentSnapshotBundleResult: FAILED,
8080
reconstitutedDocDataResult: FAILED,
8181
querySnapshotBundleResult: FAILED,
@@ -231,7 +231,7 @@ export async function testFirestore(isServer: boolean = false): Promise<TestResu
231231
const querySnapshot = await getDocs(q);
232232
if (querySnapshot.docs.length === 1) {
233233
if (querySnapshot.docs[0].data().testbool === false) {
234-
result.querySnapshotResult = OK;
234+
result.querySnapshotGetDocsResult = OK;
235235
}
236236
}
237237

0 commit comments

Comments
 (0)