Skip to content
This repository was archived by the owner on May 19, 2025. It is now read-only.

Commit b8700b5

Browse files
authored
Merge pull request #268 from howking/master
Fixes for firebase-storage typo comments, refer to __putString method and supress log message
2 parents 645371a + c5ba4ec commit b8700b5

File tree

4 files changed

+26
-8
lines changed

4 files changed

+26
-8
lines changed

firebase-storage-behavior.html

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,14 @@
5050
forceUnique: {
5151
type: Boolean,
5252
value: false
53+
},
54+
55+
/**
56+
* When true, will perform detailed logging.
57+
*/
58+
log: {
59+
type: Boolean,
60+
value: false
5361
}
5462
},
5563

@@ -88,7 +96,17 @@
8896
return storage.ref(path);
8997
},
9098

91-
__pathChanged: function(path) {}
99+
__pathChanged: function(path) {},
100+
101+
/**
102+
* A wrapper around `console.log`.
103+
*/
104+
_log: function() {
105+
if (this.log) {
106+
console.log.apply(console, arguments);
107+
}
108+
}
109+
92110
};
93111

94112
/** @polymerBehavior */

firebase-storage-multiupload.html

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,14 +52,14 @@
5252
*
5353
* file-task
5454
*
55-
* <file-storage-upload-task
55+
* <firebase-storage-upload-task
5656
* task="[[item]]""
5757
* bytes-transferred="{{bytesTransferred}}"
5858
* total-bytes="{{totalBytes}}"
5959
* state="{{state}}"
6060
* download-url="{{downloadUrl}}"
6161
* metadata="{{metadata}}"
62-
* path="{{path}}"></file-storage-upload-task>
62+
* path="{{path}}"></firebase-storage-upload-task>
6363
*
6464
* ```
6565
*
@@ -73,14 +73,14 @@
7373
* </firebase-storage-multiupload>
7474
*
7575
* <template is="dom-repeat" items="[[uploadTasks]]">
76-
* <file-storage-upload-task
76+
* <firebase-storage-upload-task
7777
* task="[[item]]""
7878
* bytes-transferred="{{item.bytesTransferred}}"
7979
* total-bytes="{{item.totalBytes}}"
8080
* state="{{item.state}}"
8181
* download-url="{{item.downloadUrl}}"
8282
* metadata="{{item.metadata}}"
83-
* path="{{item.path}}"></file-storage-upload-task>
83+
* path="{{item.path}}"></firebase-storage-upload-task>
8484
* </template>
8585
* ```
8686
*

firebase-storage-ref.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,7 @@
160160
* Stores a string in a given format
161161
*/
162162
putString: function(data, format, metadata) {
163-
this.uploadTask = this.__put(null, data, format, metadata);
163+
this.uploadTask = this.__putString(null, data, format, metadata);
164164
return this.uploadTask;
165165
},
166166

firebase-storage-upload-task.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,14 @@
1818
*
1919
* For example:
2020
*
21-
* <file-storage-upload-task
21+
* <firebase-storage-upload-task
2222
* task="[[task]]"
2323
* bytes-transferred="{{bytesTransferred}}"
2424
* total-bytes="{{totalBytes}}"
2525
* state="{{state}}"
2626
* download-url="{{downloadUrl}}"
2727
* metadata="{{metadata}}"
28-
* path="{{path}}"></file-storage-upload-task>
28+
* path="{{path}}"></firebase-storage-upload-task>
2929
*
3030
* It has to get the upload task from either the firebase-storage-multiupload or firebase-storage-ref
3131
* and produces data like bytes-transferred, total-bytes, states, etc...

0 commit comments

Comments
 (0)