Merge pull request #205 from Alos/compiler-fixes

Made changes to allow compilation with closure compiler

Author: e111077

firebase-app.html

@@ -92,6 +92,7 @@
           /**
            * The Firebase app object constructed from the other fields of
            * this element.
+           * @type {firebase.app.App}
            */
           app: {
             type: Object,

firebase-common-behavior.html

@@ -16,6 +16,11 @@
     /** @polymerBehavior Polymer.FirebaseCommonBehavior */
     Polymer.FirebaseCommonBehaviorImpl = {
       properties: {
+
+
+        /**
+        * @type {!firebase.app.App|undefined}
+        */
         app: {
           type: Object,
           notify: true,

firebase-database-behavior.html

@@ -30,11 +30,12 @@
 
         /**
          * Path to a Firebase root or endpoint. N.B. `path` is case sensitive.
+         * @type {string|null}
          */
         path: {
           type: String,
-          observer: '__pathChanged',
-          value: null
+          value: null,
+          observer: '__pathChanged'
         },
 
         /**
@@ -52,6 +53,10 @@
         '__onlineChanged(online)'
       ],
 
+      /**
+       * Set the firebase value.
+       * @return {!firebase.Promise<void>}
+       */
       _setFirebaseValue: function(path, value) {
         this._log('Setting Firebase value at', path, 'to', value)
         var key = value && value.$key;

firebase-document.html

@@ -49,16 +49,12 @@
       }
     },
 
-    /**
-     * @override
-     */
+
     get isNew() {
       return this.disabled || !this.__pathReady(this.path);
     },
 
-    /**
-     * @override
-     */
+
     get zeroValue() {
       return {};
     },
@@ -73,11 +69,11 @@
      *     not given, a random key will be generated and used.
      * @return {Promise} A promise that resolves once this.data has been
      *     written to the new path.
-     * @override
+     *
      */
     saveValue: function(parentPath, key) {
       return new Promise(function(resolve, reject) {
-        var path;
+        var path = null;
 
         if (!this.app) {
           reject(new Error('No app configured!'));
@@ -102,26 +98,17 @@
       }.bind(this));
     },
 
-    /**
-     * @override
-     */
     reset: function() {
       this.path = null;
       return Promise.resolve();
     },
 
-    /**
-     * @override
-     */
     destroy: function() {
       return this._setFirebaseValue(this.path, null).then(function() {
         return this.reset();
       }.bind(this));
     },
 
-    /**
-     * @override
-     */
     memoryPathToStoragePath: function(path) {
       var storagePath = this.path;
 
@@ -132,9 +119,6 @@
       return storagePath;
     },
 
-    /**
-     * @override
-     */
     storagePathToMemoryPath: function(storagePath) {
       var path = 'data';
 
@@ -148,9 +132,6 @@
       return path;
     },
 
-    /**
-     * @override
-     */
     getStoredValue: function(path) {
       return new Promise(function(resolve, reject) {
         this.db.ref(path).once('value', function(snapshot) {
@@ -163,9 +144,6 @@
       }.bind(this));
     },
 
-    /**
-     * @override
-     */
     setStoredValue: function(path, value) {
       return this._setFirebaseValue(path, value);
     },

firebase-messaging.html

@@ -68,7 +68,13 @@
     (function() {
       var stateMap = {};
 
-      function applyAll(app, method) {
+      /**
+       *
+       * @param {Object} app
+       * @param {string} method
+       * @param {...*} var_args
+      */
+      function applyAll(app, method, var_args) {
         var args = Array.prototype.slice.call(arguments, 2);
         stateMap[app.name].instances.forEach(function(el) {
           el[method].apply(el, args);
@@ -131,6 +137,7 @@
            * The current registration token for this session. Save this
            * somewhere server-accessible so that you can target push messages
            * to this device.
+           * @type {String}
            */
           token: {
             type: String,
@@ -222,7 +229,7 @@
          * must be called after initialization to start listening for push
          * messages.
          *
-         * @param {ServiceWorkerRegistration} swreg the custom service worker registration with which to activate
+         * @param {ServiceWorkerRegistration=}  swreg the custom service worker registration with which to activate
          */
         activate: function(swreg) {
           this.statusKnown = false;

firebase-query.html

@@ -179,9 +179,6 @@
           return [];
         },
 
-        /**
-         * @override
-         */
         memoryPathToStoragePath: function(path) {
           var storagePath = this.path;
 
@@ -199,9 +196,6 @@
           return storagePath;
         },
 
-        /**
-         * @override
-         */
         storagePathToMemoryPath: function(storagePath) {
           var path = 'data';
 
@@ -220,9 +214,6 @@
           return path;
         },
 
-        /**
-         * @override
-         */
         setStoredValue: function(storagePath, value) {
           if (storagePath === this.path || /\$key$/.test(storagePath)) {
             return Promise.resolve();
@@ -276,15 +267,11 @@
           return query;
         },
 
-        /**
-         * `@override`
-         */
-
         __pathChanged: function(path, oldPath) {
           // we only need to reset the data if the path is null (will also trigged when this element initiates)
           // When path changes and is not null, it triggers a ref change (via __computeRef(db,path)), which then triggers a __queryChanged setting data to zeroValue
 
-          if (path == null ) {
+          if (path == null) {
             this.syncToMemory(function() {
               this.data = this.zeroValue;
             });

firebase-storage-script.html

@@ -1 +1 @@
-<script src="../firebase/firebase-storage.js"></script>
+<script src="../firebase/firebase-storage.js"></script>