Better implementation of _isArray() and _toArray() helpers within ReactFireMixin.

Author: jacobawenger

CHANGELOG.md

@@ -1,3 +1,9 @@
+v0.1.1
+-------------
+Release Date: 2014-05-02
+
+  * Better implementation of _isArray() and _toArray() helpers
+
 v0.1.0
 -------------
 Release Date: 2014-04-30

ReactFireMixin.js

@@ -53,45 +53,22 @@ var ReactFireMixin = {
   /*************/
   /*  HELPERS  */
   /*************/
-  /* Returns true if the inputted object is a number */
-  _isNumeric: function(obj) {
-    try {
-      return (((obj - 0) == obj) && (obj.length > 0));
-    } catch (e) {
-      return false;
-    } // try
-  }, // isNumeric()
-
   /* Returns true if the inputted object is a JavaScript array */
   _isArray: function(obj) {
-    if (!obj) { return false; }
-    try {
-      if (!(obj.propertyIsEnumerable("length"))
-        && (typeof obj === "object")
-        && (typeof obj.length === "number")) {
-          for (var idx in obj) {
-            if (!this._isNumeric(idx)) { return false; }
-          } // for (var idx in object)
-          return true;
-      } else {
-        return false;
-      } // if (!(obj.propertyIsEnumerable("length"))...
-    } catch (e) {
-      return false;
-    } // try
-  }, // isArray()
+    return (obj && typeof obj === "object" && obj instanceof Array);
+  },
 
-  /* Converts a Firebase list to a JavaScript array */
-  _toArray: function(list) {
-    var k, out = [];
-    if (list) {
-      if (this._isArray(list)) {
+  /* Converts a Firebase object to a JavaScript array */
+  _toArray: function(obj) {
+    var out = [];
+    if (obj) {
+      if (this._isArray(obj)) {
         out = list;
       }
-      else if (typeof(list) === "object") {
-        for (k in list) {
-          if (list.hasOwnProperty(k)) {
-            out.push(list[k]);
+      else if (typeof(obj) === "object") {
+        for (var key in obj) {
+          if (obj.hasOwnProperty(key)) {
+            out.push(obj[key]);
           }
         }
       }

bower.json

@@ -1,6 +1,6 @@
 {
   "name": "ReactFire",
-  "version": "0.1.0",
+  "version": "0.1.1",
   "homepage": "https://github.com/firebase/ReactFire",
   "authors": [
     "jacobawenger <[email protected]>"

examples/todoApp/bower.json

@@ -23,6 +23,6 @@
   "dependencies": {
     "react": "~0.10.0",
     "firebase": "~1.0.12",
-    "ReactFire": "~0.1.0"
+    "ReactFire": "~0.1.1"
   }
 }