fix(cast-format): Throw exception for non-existing date (#8469)

- Also add a small unit test to verify exception throwing for non-existent date

Co-authored-by: Artyom Ivanov <[email protected]>

Author: TreeHunter9

src/common/CvtFormat.cpp

@@ -1610,7 +1610,7 @@ namespace
 		}
 	}
 
-	void validateTimeStamp(const ISC_TIMESTAMP timestamp, const EXPECT_DATETIME expectedType, const dsc* desc,
+	void validateTimeStamp(const ISC_TIMESTAMP timestamp, const tm& times, const EXPECT_DATETIME expectedType, const dsc* desc,
 		Callbacks* cb)
 	{
 		if (!NoThrowTimeStamp::isValidTimeStamp(timestamp))
@@ -1633,6 +1633,21 @@ namespace
 					break;
 			}
 		}
+
+		if (expectedType != expect_sql_time && expectedType != expect_sql_time_tz)
+		{
+			tm times2;
+			memset(&times2, 0, sizeof(decltype(times2)));
+
+			NoThrowTimeStamp::decode_date(timestamp.timestamp_date, &times2);
+
+			if (times.tm_year != times2.tm_year
+			 || times.tm_mon  != times2.tm_mon
+			 ||	times.tm_mday != times2.tm_mday)
+			{
+				CVT_conversion_error(desc, cb->err);
+			}
+		}
 	}
 
 	ISC_TIMESTAMP_TZ constructTimeStampTz(const StringToDateTimeData& cvtData, Callbacks* cb)
@@ -1709,8 +1724,8 @@ ISC_TIMESTAMP_TZ CVT_format_string_to_datetime(const dsc* desc, const Firebird::
 	processStringToDateTimeTokens(tokens, stringUpper, cvtData, cb);
 
 	ISC_TIMESTAMP_TZ timestampTZ = constructTimeStampTz(cvtData, cb);
+	validateTimeStamp(timestampTZ.utc_timestamp, cvtData.times, expectedType, desc, cb);
 	timeStampToUtc(timestampTZ, cb->getSessionTimeZone(), expectedType, cb);
-	validateTimeStamp(timestampTZ.utc_timestamp, expectedType, desc, cb);
 
 	return timestampTZ;
 }

src/common/tests/CvtTest.cpp

@@ -632,6 +632,8 @@ BOOST_AUTO_TEST_CASE(CVTStringToFormatDateTime_EXCEPTION_CHECK)
 	testExceptionCvtStringToFormatDateTime("30", "TZM", cb);
 
 	testExceptionCvtStringToFormatDateTime("12 12", "HH24 HH24", cb);
+
+	testExceptionCvtStringToFormatDateTime("2025-02-30", "YYYY-MM-DD", cb);
 }
 
 BOOST_AUTO_TEST_SUITE_END()	// FunctionalTest