Merge remote-tracking branch 'origin/master' into put_blr_type_refactoring

Author: Artyom Abakumov

doc/sql.extensions/README.schemas.md

@@ -76,6 +76,8 @@ you can reset the current search path to its initial configuration with the `ALT
 
 Nonexistent schemas can be included in the search path but are ignored during name resolution.
 
+If `SYSTEM` is not included in the schema list, it is automatically added as the last schema in the search path.
+
 The first existing schema in the search path is referred to as the **current schema** and is exclusively used in some 
 operations.
 
@@ -103,7 +105,7 @@ create or alter function F1 returns integer as begin end;
 grant create table to user USER1;
 ```
 
-For `ALTER`, `DROP`, and others statements, the system searches for the specified object across all schemas in the 
+For `ALTER`, `DROP`, and others statements, Firebird searches for the specified object across all schemas in the 
 search path. The reference is bound to the first matching object found. If no matching object exists in any schema, an 
 error is raised.
 
@@ -133,8 +135,7 @@ In this case, the search path is used to locate `TABLE1`, `DOMAIN1`, and `TABLE2
 
 For DDL statements, the search path operates similarly, but with a subtle difference. Once the object being created or 
 modified is bound to a schema during statement preparation, the search path is implicitly and temporarily modified. 
-This adjustment sets the search path to the schema of the object. Additionally, if the `SYSTEM` schema was already 
-present in the search path, it is appended as the last schema.
+This adjustment sets the search path to the schema of the object with `SYSTEM` added as the final schema in the path.
 
 ```sql
 create schema SCHEMA1;
@@ -198,8 +199,8 @@ grant select on table SCHEMA1.TABLE1 to user USER2;
 ## The SYSTEM schema
 
 All system schema-bound objects (e.g., `RDB$*` and `MON$*`) are now created in a dedicated schema called `SYSTEM`. 
-The `SYSTEM` schema has a default `USAGE` permission granted to `PUBLIC` and is included in the default search path. 
-This ensures backward compatibility with previous Firebird versions.
+The `SYSTEM` schema has a default `USAGE` permission granted to `PUBLIC` and is automatically included in the 
+search path. This ensures backward compatibility with previous Firebird versions.
 
 While the `SYSTEM` schema allows operations like index creation and manipulation of those indexes, it is otherwise 
 locked for DDL changes. Modifying objects within the `SYSTEM` schema through DDL operations is strongly discouraged.
@@ -265,6 +266,8 @@ schema exists, it returns `NULL`.
 SET SEARCH_PATH TO <schema name> [, <schema name>]...
 ```
 
+If `SYSTEM` is not included in the schema list, it is automatically added as the last schema in the search path.
+
 ### RDB$GET_CONTEXT
 
 #### CURRENT_SCHEMA (SYSTEM)
@@ -626,8 +629,7 @@ slave side. This allows mapping database objects to a specific schema using a se
 ## System packages and functions
 
 Firebird includes system packages such as `RDB$TIME_ZONE_UTIL`, `RDB$PROFILER`, and others. These system packages 
-are now located in the `SYSTEM` schema. If the `SYSTEM` schema is not included in the search path, their usage 
-requires explicit qualification with `SYSTEM`, as with any other object bound to the `SYSTEM` schema.
+are now located in the `SYSTEM` schema.
 
 In contrast, Firebird also provides non-packaged built-in functions like `RDB$GET_CONTEXT`, `ABS`, and `DATEDIFF`. 
 These functions are not listed in the database metadata (`RDB$FUNCTIONS`) and neither require nor accept the 

examples/dbcrypt/CryptApplication.cpp

@@ -32,7 +32,7 @@ using namespace Firebird;
 class CryptKey : public ICryptKeyCallbackImpl<CryptKey, CheckStatusWrapper>
 {
 public:
-	unsigned int callback(unsigned int, const void*, unsigned int length, void* buffer)
+	unsigned int callback(unsigned int, const void*, unsigned int length, void* buffer) override
 	{
 		if (length > 0 && buffer)
 		{
@@ -113,7 +113,7 @@ class App
 			throw "setDbCryptCallback";
 
 		char s[256];
-		sprintf(s, "localhost:%s", dbName);
+		snprintf(s, sizeof(s), "localhost:%s", dbName);
 		att = p->attachDatabase(status, s, 0, NULL);
 		if (status->getState() & IStatus::STATE_ERRORS)
 			throw "attachDatabase";

examples/dbcrypt/CryptKeyHolder.cpp

@@ -200,7 +200,7 @@ class CryptKeyHolder : public IKeyHolderPluginImpl<CryptKeyHolder, CheckStatusWr
 			name[sizeof(name) - 1] = 0;
 		}
 
-		unsigned int callback(unsigned int, const void*, unsigned int length, void* buffer)
+		unsigned int callback(unsigned int, const void*, unsigned int length, void* buffer) override
 		{
 			memcpy(buffer, &key, 1);
 			return 1;

examples/empbuild/empbuild.epp

@@ -74,7 +74,7 @@ else
 /* Create the database */
 
 printf ("creating database %s\n", Db_name);
-sprintf (cmd, "CREATE DATABASE \"%s\"", Db_name);
+snprintf(cmd, sizeof(cmd), "CREATE DATABASE \"%s\"", Db_name);
 gds_trans = 0;
 
 EXEC SQL EXECUTE IMMEDIATE :cmd;
@@ -94,39 +94,39 @@ if (SQLCODE)
     }
 
 printf ("Turning forced writes off\n");
-sprintf (cmd, "gfix -write async %s", Db_name);
+snprintf(cmd, sizeof(cmd), "gfix -write async %s", Db_name);
 if (system (cmd))
     {
     printf ("Couldn't turn forced writes off\n");
     exit (FINI_ERROR);
     }
 
 printf ("Creating tables\n");
-sprintf (cmd, "isql %s -q -i empddl.sql", Db_name);
+snprintf(cmd, sizeof(cmd), "isql %s -q -i empddl.sql", Db_name);
 if (system (cmd))
     {
     printf ("Couldn't create tables \n");
     exit (FINI_ERROR);
     }
 
 printf ("Turning  off indices and triggers \n");
-sprintf (cmd, "isql %s -i indexoff.sql", Db_name);
+snprintf(cmd, sizeof(cmd), "isql %s -i indexoff.sql", Db_name);
 if (system (cmd))
     {
     printf ("Couldn't turn off indices and triggers \n");
     exit (FINI_ERROR);
     }
 
 printf ("Loading  column data\n");
-sprintf (cmd, "isql %s -i empdml.sql", Db_name);
+snprintf(cmd, sizeof(cmd), "isql %s -i empdml.sql", Db_name);
 if (system (cmd))
     {
     printf ("Couldn't load column data \n");
     exit (FINI_ERROR);
     }
 
 printf ("Turning  on indices and triggers \n");
-sprintf (cmd, "isql %s -i indexon.sql", Db_name);
+snprintf(cmd, sizeof(cmd), "isql %s -i indexon.sql", Db_name);
 if (system (cmd))
     {
     printf ("Couldn't turn on indices and triggers \n");

examples/extauth/TcWrapper.cpp

@@ -58,7 +58,7 @@ void check(ThrowStatusWrapper* status, int err, const char* text)
 		return;
 
 	char buf[256];
-	sprintf(buf, "%s: %s", text, error_to_string(err));
+	snprintf(buf, sizeof(buf), "%s: %s", text, error_to_string(err));
 	error(status, buf);
 }
 

examples/interfaces/04.print_table.cpp

@@ -106,7 +106,7 @@ int main()
 
 			default:
 				{
-					sprintf(s, "Unknown type %d for %s", t, meta->getField(&status, j));
+					snprintf(s, sizeof(s), "Unknown type %d for %s", t, meta->getField(&status, j));
 					throw s;
 				}
 				continue;

examples/replication/fbSampleReplicator.cpp

@@ -124,7 +124,7 @@ static const ISC_STATUS wrn[] = { isc_arg_gds, isc_random, isc_arg_string, (ISC_
 ReplPlugin::ReplPlugin(IPluginConfig* conf)
 {
 	char fn[100];
-	sprintf(fn, "session_%08x_%d.log", (unsigned)time(nullptr), logCounter++);
+	snprintf(fn, sizeof(fn), "session_%08x_%d.log", (unsigned)time(nullptr), logCounter++);
 	log = fopen(fn, "w");
 	WriteLog(log, "%p\tReplicatedSession constructed\n", this);
 	status = master->getStatus();

examples/udr/Triggers.cpp

@@ -135,7 +135,8 @@ FB_UDR_BEGIN_TRIGGER(replicate)
 			const char* name = triggerMetadata->getField(status, i);
 
 			strcat(buffer, "    p");
-			sprintf(buffer + strlen(buffer), "%d type of column \"%s\".\"%s\" = ?", i, table, name);
+			const size_t buflen = strlen(buffer);
+			snprintf(buffer + buflen, sizeof(buffer) - buflen, "%d type of column \"%s\".\"%s\" = ?", i, table, name);
 		}
 
 		strcat(buffer,
@@ -175,7 +176,8 @@ FB_UDR_BEGIN_TRIGGER(replicate)
 			if (i > 0)
 				strcat(buffer, ", ");
 			strcat(buffer, ":p");
-			sprintf(buffer + strlen(buffer), "%d", i);
+			const size_t buflen = strlen(buffer);
+			snprintf(buffer + buflen, sizeof(buffer) - buflen, "%d", i);
 		}
 
 		strcat(buffer, ")\n        on external data source '");

src/burp/BurpTasks.cpp

@@ -902,8 +902,6 @@ void RestoreRelationTask::initItem(BurpGlobals* tdgbl, Item& item)
 				m_masterGbl->gbl_dpb_data.begin(),
 				m_masterGbl->gbl_dpb_data.getCount());
 
-			dpb.deleteWithTag(isc_dpb_gbak_attach);
-
 			const UCHAR* dpbBuffer = dpb.getBuffer();
 			const USHORT dpbLength = dpb.getBufferLength();
 

src/burp/backup.epp

@@ -3911,7 +3911,7 @@ void write_pub_tables()
 
 		if (!X.RDB$TABLE_SCHEMA_NAME.NULL)
 		{
-			PUT_TEXT(att_ptab_table_schema_name, X.RDB$TABLE_NAME);
+			PUT_TEXT(att_ptab_table_schema_name, X.RDB$TABLE_SCHEMA_NAME);
 			tableName.schema = X.RDB$TABLE_SCHEMA_NAME;
 		}