Make StatementMetadata::parse() handle isc_info_error that could be returned by pre-v6 server.

Author: hvlad

src/common/StatementMetadata.cpp

@@ -56,6 +56,7 @@ static const unsigned INFO_BUFFER_SIZE = MemoryPool::MAX_MEDIUM_BLOCK_SIZE;
 static USHORT getLen(const UCHAR** ptr, const UCHAR* bufferEnd);
 static int getNumericInfo(const UCHAR** ptr, const UCHAR* bufferEnd);
 static void getStringInfo(const UCHAR** ptr, const UCHAR* bufferEnd, string* str);
+static ISC_STATUS getErrorInfo(const UCHAR** ptr, const UCHAR* bufferEnd, UCHAR* item = nullptr);
 
 
 // Build a list of info codes based on a prepare flags bitmask.
@@ -359,6 +360,14 @@ void StatementMetadata::parse(unsigned bufferLength, const UCHAR* buffer)
 							finishDescribe = true;
 							break;
 
+						case isc_info_error:
+						{
+							const ISC_STATUS errorCode = getErrorInfo(&buffer, bufferEnd);
+							if (errorCode != isc_infunk)
+								Arg::Gds(errorCode).raise();
+							break;
+						}
+
 						default:
 							--buffer;
 							finishDescribe = true;
@@ -409,6 +418,14 @@ void StatementMetadata::parse(unsigned bufferLength, const UCHAR* buffer)
 				break;
 			}
 
+			case isc_info_error:
+			{
+				const ISC_STATUS errorCode = getErrorInfo(&buffer, bufferEnd);
+				if (errorCode != isc_infunk)
+					Arg::Gds(errorCode).raise();
+				break;
+			}
+
 			default:
 				finish = true;
 				break;
@@ -528,5 +545,27 @@ static void getStringInfo(const UCHAR** ptr, const UCHAR* bufferEnd, string* str
 	*ptr += len;
 }
 
+// Get error code and, optional, info item that caused the error.
+static ISC_STATUS getErrorInfo(const UCHAR** ptr, const UCHAR* bufferEnd, UCHAR* item)
+{
+	// Expected error code in the buffer encoded as follows:
+	// (short) clumplet lenght, (byte) item code, (long) error code
+
+	const USHORT len = getLen(ptr, bufferEnd);
+
+	if (len != 1 + sizeof(ULONG))
+		fatal_exception::raiseFmt("Invalid info structure - expected error info length %d, actual %d",
+			1 + sizeof(ULONG), len);
+
+	if (item)
+		*item = **ptr;
+
+	(*ptr)++;
+
+	const ISC_STATUS err = gds__vax_integer(*ptr, sizeof(ULONG));
+	*ptr += sizeof(ULONG);
+
+	return err;
+}
 
 }	// namespace Firebird