Replace sprintf with snprintf in cloop

Author: mrotteveel

extern/cloop/src/cloop/Expr.cpp

@@ -38,9 +38,9 @@ string IntLiteralExpr::generate(Language language, const string& prefix)
 {
 	char buffer[64];
 	if (hex)
-		sprintf(buffer, "%s%x", language == LANGUAGE_PASCAL ? "$" : "0x", value);
+		snprintf(buffer, sizeof(buffer), "%s%x", language == LANGUAGE_PASCAL ? "$" : "0x", value);
 	else
-		sprintf(buffer, "%d", value);
+		snprintf(buffer, sizeof(buffer), "%d", value);
 	return buffer;
 }
 

extern/cloop/src/cloop/Lexer.cpp

@@ -154,7 +154,7 @@ Token& Lexer::getToken(Token& token)
 			if (token.text.length() == 2)
 			{
 				char buffer[1024];
-				sprintf(buffer, "%s:%i:%i: error: Invalid hexadecimal prefix.",
+				snprintf(buffer, sizeof(buffer), "%s:%i:%i: error: Invalid hexadecimal prefix.",
 					filename.c_str(), line, column);
 				throw runtime_error(buffer);
 			}
@@ -220,7 +220,7 @@ void Lexer::skip(Char& ch)	// skip spaces and comments
 					if (ch.c == -1)
 					{
 						char buffer[1024];
-						sprintf(buffer, "%s:%i:%i: error: Unterminated comment.",
+						snprintf(buffer, sizeof(buffer), "%s:%i:%i: error: Unterminated comment.",
 							filename.c_str(),
 							firstCh.line, firstCh.column);
 						throw runtime_error(buffer);

extern/cloop/src/cloop/Parser.cpp

@@ -529,15 +529,15 @@ TypeRef Parser::parseTypeRef()
 	return typeRef;
 }
 
-void Parser::syntaxError(const Token& token)
+[[noreturn]] void Parser::syntaxError(const Token& token)
 {
 	error(token, string("Syntax error at '") + token.text + "'.");
 }
 
-void Parser::error(const Token& token, const string& msg)
+[[noreturn]] void Parser::error(const Token& token, const string& msg)
 {
 	char buffer[1024];
-	sprintf(buffer, "%s:%i:%i: error: %s",
+	snprintf(buffer, sizeof(buffer), "%s:%i:%i: error: %s",
 		lexer->filename.c_str(), token.line, token.column, msg.c_str());
 	throw runtime_error(buffer);
 }