Fix buffer overflow using string_view.

asfernandes · asfernandes · commit 31d8495a1f43 · 2024-11-27T23:07:05.000-03:00
diff --git a/src/common/CvtFormat.cpp b/src/common/CvtFormat.cpp
@@ -249,6 +249,9 @@ namespace
 
 	constexpr Format::Patterns mapFormatStrToFormatPattern(std::string_view pattern)
 	{
+		if (pattern.empty())
+			return Format::NONE;
+
 		switch (pattern[0])
 		{
 			case 'Y':

Original file line number	Diff line number	Diff line change
`@@ -249,6 +249,9 @@ namespace`
`249`	`249`
`250`	`250`	`constexpr Format::Patterns mapFormatStrToFormatPattern(std::string_view pattern)`
`251`	`251`	`{`
	`252`	`+ if (pattern.empty())`
	`253`	`+ return Format::NONE;`
	`254`	`+`
`252`	`255`	`switch (pattern[0])`
`253`	`256`	`{`
`254`	`257`	`case 'Y':`