Add replication journal cleanup when drop database (#8626)

Also add GUID to filename pattern of journal

Author: XaBbl4

src/common/os/guid.h

@@ -52,7 +52,6 @@ static_assert(sizeof(UUID) == 16, "Guid size mismatch");
 namespace Firebird {
 
 inline constexpr int GUID_BUFF_SIZE = 39;
-inline constexpr int GUID_BODY_SIZE = 36;
 
 void GenerateRandomBytes(void* buffer, FB_SIZE_T size);
 
@@ -65,8 +64,10 @@ void GenerateGuid(UUID* guid);
 class Guid
 {
 	// Some versions of MSVC cannot recognize hh specifier but MSVC 2015 has it
-	static constexpr const char* GUID_FORMAT =
-		"{%08X-%04hX-%04hX-%02hhX%02hhX-%02hhX%02hhX%02hhX%02hhX%02hhX%02hhX}";
+#define GUID_FORMAT_BASE "%08X-%04hX-%04hX-%02hhX%02hhX-%02hhX%02hhX%02hhX%02hhX%02hhX%02hhX"
+	static constexpr const char* GUID_FORMAT = "{" GUID_FORMAT_BASE "}";
+	static constexpr const char* GUID_FORMAT_WITHOUT_BRACKETS = GUID_FORMAT_BASE;
+#undef GUID_FORMAT_BASE
 	static constexpr int GUID_FORMAT_ARGS = 11;
 
 	Guid() noexcept {}
@@ -119,26 +120,25 @@ class Guid
 	}
 
 	template<typename T>
-	void toString(T& str) const
+	void toString(T& str, bool withBrackets = true) const
 	{
-		str.printf(GUID_FORMAT,
+		str.printf(withBrackets ? GUID_FORMAT : GUID_FORMAT_WITHOUT_BRACKETS,
 			m_data.Data1, m_data.Data2, m_data.Data3,
 			m_data.Data4[0], m_data.Data4[1], m_data.Data4[2], m_data.Data4[3],
 			m_data.Data4[4], m_data.Data4[5], m_data.Data4[6], m_data.Data4[7]);
 	}
 
-
-	Firebird::string toString() const
+	Firebird::string toString(bool withBrackets = true) const
 	{
 		Firebird::string result;
-		toString(result);
+		toString(result, withBrackets);
 		return result;
 	}
 
-	Firebird::PathName toPathName() const
+	Firebird::PathName toPathName(bool withBrackets = true) const
 	{
 		Firebird::PathName result;
-		toString(result);
+		toString(result, withBrackets);
 		return result;
 	}
 

src/jrd/jrd.cpp

@@ -3122,6 +3122,8 @@ JAttachment* JProvider::createDatabase(CheckStatusWrapper* user_status, const ch
 				if (attachment2)
 				{
 					allow_overwrite = attachment2->getHandle()->locksmith(tdbb, DROP_DATABASE);
+					if (allow_overwrite)
+						REPL_journal_cleanup(attachment2->getHandle()->att_database);
 					attachment2->detach(user_status);
 				}
 				else
@@ -3612,6 +3614,9 @@ void JAttachment::internalDropDatabase(CheckStatusWrapper* user_status)
 				throw;
 			}
 
+			// Unlink active replication segments
+			REPL_journal_cleanup(dbb);
+
 			// Unlink attachment from database
 			release_attachment(tdbb, attachment, &threadGuard);
 			att = NULL;

src/jrd/replication/ChangeLog.cpp

@@ -73,7 +73,7 @@ namespace
 
 	inline constexpr unsigned COPY_BLOCK_SIZE = 64 * 1024; // 64 KB
 
-	inline constexpr const char* FILENAME_PATTERN = "%s.journal-%09" UQUADFORMAT;
+	inline constexpr const char* FILENAME_PATTERN = "%s_%s.journal-%09" UQUADFORMAT;
 
 	inline constexpr const char* FILENAME_WILDCARD = "$(filename)";
 	inline constexpr const char* PATHNAME_WILDCARD = "$(pathname)";
@@ -885,6 +885,26 @@ void ChangeLog::bgArchiver()
 	}
 }
 
+void ChangeLog::cleanup()
+{
+	LockGuard guard(this);
+
+	while (m_segments.hasData())
+	{
+		const auto segment = m_segments.pop();
+
+		if (segment->getState() == SEGMENT_STATE_USED && segment->hasData())
+			segment->setState(SEGMENT_STATE_FULL);
+
+		if (segment->getState() == SEGMENT_STATE_FULL)
+			archiveSegment(segment);
+
+		const PathName filename = segment->getPathName();
+		segment->release();
+		unlink(filename.c_str());
+	}
+}
+
 void ChangeLog::initSegments()
 {
 	clearSegments();
@@ -939,7 +959,7 @@ ChangeLog::Segment* ChangeLog::createSegment()
 	const auto sequence = state->sequence + 1;
 
 	PathName filename;
-	filename.printf(FILENAME_PATTERN, m_config->filePrefix.c_str(), sequence);
+	filename.printf(FILENAME_PATTERN, m_config->filePrefix.c_str(), m_guid.toString(false).c_str(), sequence);
 	filename = m_config->journalDirectory + filename;
 
 	const auto fd = os_utils::openCreateSharedFile(filename.c_str(), O_EXCL | O_BINARY);
@@ -989,7 +1009,7 @@ ChangeLog::Segment* ChangeLog::reuseSegment(ChangeLog::Segment* segment)
 	// Attempt to rename the backing file
 
 	PathName newname;
-	newname.printf(FILENAME_PATTERN, m_config->filePrefix.c_str(), sequence);
+	newname.printf(FILENAME_PATTERN, m_config->filePrefix.c_str(), m_guid.toString(false).c_str(), sequence);
 	newname = m_config->journalDirectory + newname;
 
 	// If renaming fails, then we just create a new file.

src/jrd/replication/ChangeLog.h

@@ -213,6 +213,7 @@ namespace Replication
 		FB_UINT64 write(ULONG length, const UCHAR* data, bool sync);
 
 		void bgArchiver();
+		void cleanup();
 
 	private:
 		void initSharedFile();

src/jrd/replication/Manager.h

@@ -88,6 +88,12 @@ namespace Replication
 				m_changeLog->forceSwitch();
 		}
 
+		void journalCleanup()
+		{
+			if (m_changeLog)
+				m_changeLog->cleanup();
+		}
+
 		const Replication::Config* getConfig() const
 		{
 			return m_config;

src/jrd/replication/Publisher.cpp

@@ -707,3 +707,9 @@ void REPL_journal_switch(thread_db* tdbb)
 
 	replMgr->forceJournalSwitch();
 }
+
+void REPL_journal_cleanup(Database* dbb)
+{
+	if (const auto replMgr = dbb->replManager(true))
+		replMgr->journalCleanup();
+}

src/jrd/replication/Publisher.h

@@ -27,6 +27,7 @@ namespace Jrd
 {
 	class thread_db;
 	class jrd_tra;
+	class Database;
 	class Savepoint;
 	struct record_param;
 }
@@ -47,5 +48,6 @@ void REPL_gen_id(Jrd::thread_db* tdbb, SLONG genId, SINT64 value);
 void REPL_exec_sql(Jrd::thread_db* tdbb, Jrd::jrd_tra* transaction, const Firebird::string& sql,
 	const Firebird::ObjectsArray<Firebird::MetaString>& schemaSearchPath);
 void REPL_journal_switch(Jrd::thread_db* tdbb);
+void REPL_journal_cleanup(Jrd::Database* dbb);
 
 #endif // JRD_REPLICATION_PUBLISHER_H