Use explicit way to update calculate SQL length

Author: Artyom Abakumov

src/jrd/trace/TraceDSQLHelpers.h

@@ -53,16 +53,14 @@ class TraceDSQLPrepare
 
 		m_start_clock = fb_utils::query_performance_counter();
 
-		if (m_string == nullptr || (m_string_len == 0 && (m_string_len = fb_strlen(m_string)) == 0))
-		{
-			static constexpr const char* empty_string = "<empty statement>";
-			static FB_SIZE_T empty_string_length = fb_strlen(empty_string);
-
-			m_string = empty_string;
-			m_string_len = empty_string_length;
-		}
+		if (m_string == nullptr)
+			traceEmptyStatement();
 		else if (m_string_len == 0)
+		{
 			m_string_len = fb_strlen(m_string);
+			if (m_string_len == 0)
+				traceEmptyStatement();
+		}
 	}
 
 	~TraceDSQLPrepare()
@@ -102,6 +100,15 @@ class TraceDSQLPrepare
 	}
 
 private:
+	void traceEmptyStatement()
+	{
+		static constexpr const char* empty_string = "<empty statement>";
+		static FB_SIZE_T empty_string_length = fb_strlen(empty_string);
+
+		m_string = empty_string;
+		m_string_len = empty_string_length;
+	}
+
 	bool m_need_trace;
 	Attachment* m_attachment;
 	jrd_tra* const m_transaction;