Fix gbak backup to work with v6 engines

Author: asfernandes

src/burp/BurpTasks.cpp

@@ -531,6 +531,11 @@ void BackupRelationTask::initItem(BurpGlobals* tdgbl, Item& item)
 
 			if (status->getState() & IStatus::STATE_ERRORS)
 				BURP_abort(&status);
+
+			item.m_att->execute(&status, item.m_tra, 0, m_masterGbl->setSearchPath.c_str(),
+				SQL_DIALECT_CURRENT, nullptr, nullptr, nullptr, nullptr);
+
+			fb_assert(status->isSuccess());
 		}
 
 		tdgbl->db_handle = item.m_att;

src/burp/OdsDetection.h

@@ -69,6 +69,7 @@ const int DB_VERSION_DDL11_2	= 112; // ods11.2 db, FB2.5
 const int DB_VERSION_DDL12		= 120; // ods12.0 db, FB3.0
 const int DB_VERSION_DDL13		= 130; // ods13.0 db, FB4.0
 const int DB_VERSION_DDL13_1	= 131; // ods13.1 db, FB5.0
+const int DB_VERSION_DDL14		= 140; // ods14.0 db, FB6.0
 
 const int DB_VERSION_OLDEST_SUPPORTED = DB_VERSION_DDL8;  // IB4.0 is ods8
 

src/burp/backup.epp

@@ -45,6 +45,7 @@
 #include "../burp/burp.h"
 #include "../jrd/ods.h"
 #include "../jrd/align.h"
+#include "../jrd/intl.h"
 #include "../common/gdsassert.h"
 #include "../jrd/constants.h"
 #include "../common/stuff.h"
@@ -286,6 +287,63 @@ int BACKUP_backup(const TEXT* dbb_file, const TEXT* file_name)
 			tdgbl->gbl_sw_par_workers = 1;
 	}
 
+	// decide what type of database we've got
+
+	detectRuntimeODS();
+	if (tdgbl->runtimeODS < DB_VERSION_OLDEST_SUPPORTED)
+	{
+		BURP_error(348, true, SafeArg() << tdgbl->runtimeODS);
+		// msg 348 database format @1 is too old to backup
+	}
+	else if (tdgbl->runtimeODS >= DB_VERSION_DDL13_1)
+	{
+		static constexpr UCHAR ODS_INFO[] = {
+			isc_info_ods_version,
+			isc_info_end
+		};
+		UCHAR infoBuffer[16];
+		USHORT odsMajorVersion;
+
+		FbLocalStatus checkStatus;
+
+		tdgbl->db_handle->getInfo(&checkStatus, sizeof(ODS_INFO), ODS_INFO, sizeof(infoBuffer), infoBuffer);
+
+		if (checkStatus.isSuccess() && infoBuffer[0] == isc_info_ods_version)
+		{
+			USHORT len = isc_portable_integer(&infoBuffer[1], 2);
+			odsMajorVersion = isc_portable_integer(&infoBuffer[3], len);
+
+			if (odsMajorVersion > ODS_VERSION13)
+				tdgbl->runtimeODS = DB_VERSION_DDL14;
+		}
+		else
+			fb_assert(false);
+	}
+
+	if (tdgbl->runtimeODS >= DB_VERSION_DDL14)
+	{
+		const char* getSchemasSql =
+			R""(SELECT LIST('"' || REPLACE(TRIM(RDB$SCHEMA_NAME), '"', '""') || '"') FROM RDB$SCHEMAS)"";
+		BurpSql getSchemasQuery(tdgbl, getSchemasSql);
+
+		FB_MESSAGE(GetSchemas, ThrowWrapper,
+			(FB_INTL_VARCHAR(4096 * METADATA_BYTES_PER_CHAR, CS_METADATA), schemaList)
+		) getSchemas(&tdgbl->throwStatus, MasterInterfacePtr());
+
+		getSchemasQuery.singleSelect(tdgbl->tr_handle, &getSchemas);
+
+		fb_assert(!getSchemas->schemaListNull);
+
+		if (!getSchemas->schemaListNull)
+		{
+			const string schemaList(getSchemas->schemaList.str, getSchemas->schemaList.length);
+			tdgbl->setSearchPath = "SET SEARCH_PATH TO " + schemaList;
+
+			BurpSql searchPathQuery(tdgbl, tdgbl->setSearchPath.c_str());
+			searchPathQuery.execute(tdgbl->tr_handle);
+		}
+	}
+
 	// detect if MAKE_DBKEY is supported and decide kind of read relation query
 	if (tdgbl->gbl_sw_par_workers > 1)
 	{
@@ -306,15 +364,6 @@ int BACKUP_backup(const TEXT* dbb_file, const TEXT* file_name)
 		// msg 410 use up to @1 parallel workers
 	}
 
-	// decide what type of database we've got
-
-	detectRuntimeODS();
-	if (tdgbl->runtimeODS < DB_VERSION_OLDEST_SUPPORTED)
-	{
-		BURP_error(348, true, SafeArg() << tdgbl->runtimeODS);
-		// msg 348 database format @1 is too old to backup
-	}
-
 	// Write burp record first with other valuable information
 	// In case of split operation, write a 'split' header first to all the files
 

src/burp/burp.h

@@ -977,7 +977,8 @@ class BurpGlobals : public Firebird::ThreadData, public GblPool
 		  flag_on_line(true),
 		  firstMap(true),
 		  firstDbc(true),
-		  stdIoMode(false)
+		  stdIoMode(false),
+		  setSearchPath(getPool())
 	{
 		// this is VERY dirty hack to keep current (pre-FB2) behaviour
 		memset (&gbl_database_file_name, 0,
@@ -1220,6 +1221,8 @@ class BurpGlobals : public Firebird::ThreadData, public GblPool
 	Firebird::AutoPtr<Firebird::SimilarToRegex> skipDataMatcher;
 	Firebird::AutoPtr<Firebird::SimilarToRegex> includeDataMatcher;
 
+	Firebird::string setSearchPath;
+
 public:
 	Firebird::string toSystem(const Firebird::PathName& from);
 
@@ -1293,7 +1296,7 @@ class BurpSql : public Firebird::AutoStorage
 		: Firebird::AutoStorage(),
 		  tdgbl(g), stmt(nullptr)
 	{
-		stmt = tdgbl->db_handle->prepare(&tdgbl->throwStatus, tdgbl->tr_handle, 0, sql, 3, 0);
+		stmt = tdgbl->db_handle->prepare(&tdgbl->throwStatus, tdgbl->tr_handle, 0, sql, SQL_DIALECT_CURRENT, 0);
 	}
 
 	template <typename M>

src/jrd/constants.h

@@ -483,4 +483,7 @@ const int WITH_ADMIN_OPTION = 2;
 // Max length of the string returned by ERROR_TEXT context variable
 const USHORT MAX_ERROR_MSG_LENGTH = 1024 * METADATA_BYTES_PER_CHAR; // 1024 UTF-8 characters
 
+// In v6 this is in consts_pub.h, but in v5 this should better be private
+inline constexpr int isc_dpb_search_path = 105;
+
 #endif // JRD_CONSTANTS_H