Use string_view, not const string_view&

Author: mrotteveel

src/common/StatusArg.h

@@ -221,7 +221,7 @@ class StatusVector : public Base
 		return *this;
 	}
 
-	StatusVector& operator<<(const std::string_view& text) noexcept
+	StatusVector& operator<<(std::string_view text) noexcept
 	{
 		implementation->shiftLeft(string(text.data(), static_cast<string::size_type>(text.length())));
 		return *this;

src/common/classes/fb_string.h

@@ -739,7 +739,7 @@ namespace Firebird
 		{
 			return assign(first, last - first);
 		}
-		StringType& assign(const std::string_view& s)
+		StringType& assign(std::string_view s)
 		{
 			return assign(s.data(), static_cast<size_type>(s.length()));
 		}

src/common/tests/StringTest.cpp

@@ -14,7 +14,7 @@ static constexpr char lbl[] = "0123456789";
 #define validate(A, B) BOOST_TEST(std::string_view(A.c_str(), A.length()) == std::string_view(B))
 #define check(A, B) BOOST_TEST(A == B)
 
-static constexpr string::size_type length(const std::string_view& str) noexcept
+static constexpr string::size_type length(std::string_view str) noexcept
 {
 	return static_cast<string::size_type>(str.length());
 }