Fixed bug #8331 : Crash of fbclient.dll on Windows

hvlad · hvlad · commit 684bb87f6477 · 2024-11-27T22:40:07.000+02:00
diff --git a/src/remote/client/interface.cpp b/src/remote/client/interface.cpp
@@ -7727,7 +7727,7 @@ static rem_port* analyze(ClntAuthBlock& cBlock, PathName& attach_name, unsigned
 		{
 #ifdef TRUSTED_AUTH
 			const char* const pluginName = cBlock.plugins.name();
-			if (legacySSP || fb_utils::stricmp(pluginName, "WIN_SSPI") != 0)
+			if (legacySSP || !pluginName || fb_utils::stricmp(pluginName, "WIN_SSPI") != 0)
 				throw;
 
 			// Retry connect with failed plugin only and using legacy security package

Original file line number	Diff line number	Diff line change
`@@ -7727,7 +7727,7 @@ static rem_port* analyze(ClntAuthBlock& cBlock, PathName& attach_name, unsigned`
`7727`	`7727`	`{`
`7728`	`7728`	`#ifdef TRUSTED_AUTH`
`7729`	`7729`	`const char* const pluginName = cBlock.plugins.name();`
`7730`		`- if (legacySSP \|\| fb_utils::stricmp(pluginName, "WIN_SSPI") != 0)`
	`7730`	`+ if (legacySSP \|\| !pluginName \|\| fb_utils::stricmp(pluginName, "WIN_SSPI") != 0)`
`7731`	`7731`	`throw;`
`7732`	`7732`
`7733`	`7733`	`// Retry connect with failed plugin only and using legacy security package`