Fix a crash appeared after the bugfix for #8185 (SIGSEGV with WHERE CURRENT OF statement with statement cache turned on). Reproducible with QA test bugs.core_5231 (release build only). This fix is a very simple one, just to avoid the object state being read after its possible removal. The returned usage counter is not used anyway.

Author: dyemanov

src/dsql/DsqlStatements.cpp

@@ -56,26 +56,22 @@ void DsqlStatement::rethrowDdlException(status_exception& ex, bool metadataUpdat
 	status_exception::raise(newVector);
 }
 
-int DsqlStatement::release()
+void DsqlStatement::release()
 {
 	fb_assert(refCounter.value() > 0);
-	int refCnt = --refCounter;
 
-	if (!refCnt)
+	if (!--refCounter)
 	{
 		if (cacheKey)
 		{
 			dsqlAttachment->dbb_statement_cache->statementGoingInactive(cacheKey);
-			refCnt = refCounter;
 		}
 		else
 		{
 			doRelease();
 			dsqlAttachment->deletePool(&getPool());
 		}
 	}
-
-	return refCnt;
 }
 
 void DsqlStatement::doRelease()

src/dsql/DsqlStatements.h

@@ -83,12 +83,12 @@ class DsqlStatement : public Firebird::PermanentStorage
 	virtual ~DsqlStatement() = default;
 
 public:
-	int addRef()
+	void addRef()
 	{
-		return ++refCounter;
+		++refCounter;
 	}
 
-	int release();
+	void release();
 
 	bool isCursorBased() const
 	{