Fixed crash after calling incorrectly parametrized request

Ev3nt · Ev3nt · commit 700f474e0902 · 2025-07-23T11:05:22.000+03:00
diff --git a/src/jrd/extds/ExtDS.cpp b/src/jrd/extds/ExtDS.cpp
@@ -2273,13 +2273,16 @@ void Statement::setInParams(thread_db* tdbb, const MetaName* const* names,
 			const MetaString* sqlName = m_sqlParamsMap[sqlNum];
 
 			unsigned int num = 0;
-			for (; num < count; num++)
+			if (names)
 			{
-				if (*names[num] == *sqlName)
-					break;
+				for (; num < count; num++)
+				{
+					if (*names[num] == *sqlName)
+						break;
+				}
 			}
 
-			if (num == count)
+			if (!names || (num == count))
 			{
 				m_error = true;
 				// Input parameter ''@1'' have no value set

Original file line number	Diff line number	Diff line change
`@@ -2273,13 +2273,16 @@ void Statement::setInParams(thread_db* tdbb, const MetaName* const* names,`
`2273`	`2273`	`const MetaString* sqlName = m_sqlParamsMap[sqlNum];`
`2274`	`2274`
`2275`	`2275`	`unsigned int num = 0;`
`2276`		`- for (; num < count; num++)`
	`2276`	`+ if (names)`
`2277`	`2277`	`{`
`2278`		`- if (names[num] == sqlName)`
`2279`		`- break;`
	`2278`	`+ for (; num < count; num++)`
	`2279`	`+ {`
	`2280`	`+ if (names[num] == sqlName)`
	`2281`	`+ break;`
	`2282`	`+ }`
`2280`	`2283`	`}`
`2281`	`2284`
`2282`		`- if (num == count)`
	`2285`	`+ if (!names \|\| (num == count))`
`2283`	`2286`	`{`
`2284`	`2287`	`m_error = true;`
`2285`	`2288`	`// Input parameter ''@1'' have no value set`