Fixed bug #8331 : Crash of fbclient.dll on Windows

hvlad · hvlad · commit 7fffc67c10b8 · 2024-11-27T22:43:47.000+02:00
diff --git a/src/remote/client/interface.cpp b/src/remote/client/interface.cpp
@@ -7328,7 +7328,7 @@ static rem_port* analyze(ClntAuthBlock& cBlock, PathName& attach_name, unsigned
 		{
 #ifdef TRUSTED_AUTH
 			const char* const pluginName = cBlock.plugins.name();
-			if (legacySSP || fb_utils::stricmp(pluginName, "WIN_SSPI") != 0)
+			if (legacySSP || !pluginName || fb_utils::stricmp(pluginName, "WIN_SSPI") != 0)
 				throw;
 
 			// Retry connect with failed plugin only and using legacy security package

Original file line number	Diff line number	Diff line change
`@@ -7328,7 +7328,7 @@ static rem_port* analyze(ClntAuthBlock& cBlock, PathName& attach_name, unsigned`
`7328`	`7328`	`{`
`7329`	`7329`	`#ifdef TRUSTED_AUTH`
`7330`	`7330`	`const char* const pluginName = cBlock.plugins.name();`
`7331`		`- if (legacySSP \|\| fb_utils::stricmp(pluginName, "WIN_SSPI") != 0)`
	`7331`	`+ if (legacySSP \|\| !pluginName \|\| fb_utils::stricmp(pluginName, "WIN_SSPI") != 0)`
`7332`	`7332`	`throw;`
`7333`	`7333`
`7334`	`7334`	`// Retry connect with failed plugin only and using legacy security package`