Initialize fields

Author: mrotteveel

examples/dbcrypt/CryptApplication.cpp

@@ -56,15 +56,14 @@ class CryptKey : public ICryptKeyCallbackImpl<CryptKey, CheckStatusWrapper>
 	static const char k;
 };
 
-const char CryptKey::k = 0x5a;
+constexpr char CryptKey::k = 0x5a;
 
 class App
 {
 public:
 	App() :
 		master(fb_get_master_interface()),
-		statusWrapper(master->getStatus()), status(&statusWrapper),
-		p(NULL), att(NULL), tra(NULL)
+		statusWrapper(master->getStatus()), status(&statusWrapper)
 	{ }
 
 	~App()
@@ -188,7 +187,7 @@ class App
 		}
 
 		printf("\nProviding key for crypt plugin - press enter to continue ...");
-		getchar();
+		(void) getchar();
 
 		att->detach(status);
 		if (status->getState() & IStatus::STATE_ERRORS)
@@ -209,10 +208,10 @@ class App
 	IMaster* master;
 	CheckStatusWrapper statusWrapper;
 	CheckStatusWrapper* status;
-	IProvider* p;
-	IAttachment* att;
-	ITransaction* tra;
-	IResultSet* curs;
+	IProvider* p = nullptr;
+	IAttachment* att = nullptr;
+	ITransaction* tra = nullptr;
+	IResultSet* curs = nullptr;
 
 	CryptKey key;
 };

src/include/firebird/Message.h

@@ -102,7 +102,7 @@
 			return getData();	\
 		}	\
 		\
-		Type data;	\
+		Type data{};	\
 		::Firebird::MessageDesc desc;	\
 	}