Skip execution of AFTER UPDATE system ref constraints triggers if update have not changed key fields.

Author: hvlad

src/jrd/exe.cpp

@@ -1157,6 +1157,17 @@ void EXE_execute_triggers(thread_db* tdbb,
 	{
 		for (TrigVector::iterator ptr = vector->begin(); ptr != vector->end(); ++ptr)
 		{
+			// The system trigger that implement cascading action can be skipped if
+			// no PK/UK field have been changed by UPDATE.
+
+			if ((which_trig == StmtNode::POST_TRIG) && (trigger_action == TRIGGER_UPDATE) &&
+				(ptr->sysTrigger == fb_sysflag_referential_constraint))
+			{
+				fb_assert(new_rpb);
+				if (!(new_rpb->rpb_runtime_flags & RPB_uk_updated))
+					continue;
+			}
+
 			if (trigger_action == TRIGGER_DDL && ddl_action)
 			{
 				// Skip triggers not matching our action

src/jrd/idx.cpp

@@ -1283,6 +1283,8 @@ void IDX_modify(thread_db* tdbb,
 	RelationPages* relPages = org_rpb->rpb_relation->getPages(tdbb);
 	WIN window(relPages->rel_pg_space_id, -1);
 
+	new_rpb->rpb_runtime_flags &= ~RPB_uk_updated;
+
 	while (BTR_next_index(tdbb, org_rpb->rpb_relation, transaction, &idx, &window))
 	{
 		IndexErrorContext context(new_rpb->rpb_relation, &idx);
@@ -1346,6 +1348,9 @@ void IDX_modify(thread_db* tdbb,
 		{
 			context.raise(tdbb, error_code, new_rpb->rpb_record);
 		}
+
+		if (idx.idx_flags & (idx_primary | idx_unique))
+			new_rpb->rpb_runtime_flags |= RPB_uk_updated;
 	}
 }
 

src/jrd/req.h

@@ -136,6 +136,7 @@ const USHORT RPB_undo_data		= 0x02;	// data got from undo log
 const USHORT RPB_undo_read		= 0x04;	// read was performed using the undo log
 const USHORT RPB_undo_deleted	= 0x08;	// read was performed using the undo log, primary version is deleted
 const USHORT RPB_just_deleted	= 0x10;	// record was just deleted by us
+const USHORT RPB_uk_updated		= 0x20;	// set by IDX_modify if it insert key into any primary or unique index
 
 const USHORT RPB_UNDO_FLAGS		= (RPB_undo_data | RPB_undo_read | RPB_undo_deleted);
 const USHORT RPB_CLEAR_FLAGS	= (RPB_UNDO_FLAGS | RPB_just_deleted);