Task #8667: Cleanup deprecated Redirection

Author: AlexPeshkoff

builds/install/misc/firebird.conf

@@ -1054,44 +1054,6 @@
 #IpcName = FIREBIRD
 
 
-# ============================
-# Settings for Unix/Linux platforms
-# ============================
-
-# ----------------------------
-# Remove protection against redirecting requests to other servers
-#
-#     ***DEPRECATED*** ***DEPRECATED*** ***DEPRECATED***
-#
-# This feature was partially broken in Firebird 3 with early (in remote listener)
-# user authentication. Not all plugins can be used with Redirection.
-# No matter of that we did not receive related bug reports, i.e. it's unused.
-# Therefore Redirection is declared DEPRECATED in Firebird 5 and will be removed
-# in Firebird 6.
-#
-#     ***WARNING*** ***WARNING*** ***WARNING*** ***WARNING***
-#
-# Ability to redirect requests to other servers was initially present
-# in Interbase, but was broken by Borland in Interbase 6.0, when
-# they added SQL dialects. Request redirection was fixed in Firebird 2.0,
-# but today such behaviour (proxy) seems to be dangerous from security
-# point of view. Imagine, you have one carefully protected Firebird server,
-# access to which is possible from global net. But in case when this server
-# has access to your internal LAN (may and should be restricted,
-# but often possible), it will work as a gateway for incoming requests like:
-# firebird.your.domain.com:internal_server:/private/database.fdb
-# It's enough to know name/IP of some internal server on your LAN, and for
-# this connection, one even need not know login/password on external server.
-# Such gateway easily overrides firewall, installed to protect your LAN
-# from outside attack.
-#
-# DO NOT ENABLE THIS OPTION UNLESS YOU REALLY KNOW WHAT YOU ARE DOING.
-#
-# Type: boolean
-#
-#Redirection = 0
-
-
 # ----------------------------
 # Settings for Architecture Configuration
 #

src/common/config/config.h

@@ -150,7 +150,6 @@ enum ConfigKey
 	KEY_TRACE_DSQL,
 	KEY_LEGACY_HASH,
 	KEY_GC_POLICY,
-	KEY_REDIRECTION,
 	KEY_DATABASE_GROWTH_INCREMENT,
 	KEY_TRACE_CONFIG,
 	KEY_MAX_TRACELOG_SIZE,
@@ -252,7 +251,6 @@ inline constexpr ConfigEntry entries[MAX_CONFIG_KEY] =
 	{TYPE_INTEGER,	"TraceDSQL",				true,	0},			// bitmask
 	{TYPE_BOOLEAN,	"LegacyHash",				true,	true},		// let use old passwd hash verification
 	{TYPE_STRING,	"GCPolicy",					false,	nullptr},	// garbage collection policy
-	{TYPE_BOOLEAN,	"Redirection",				true,	false},
 	{TYPE_INTEGER,	"DatabaseGrowthIncrement",	false,	128 * 1048576},	// bytes
 	{TYPE_STRING,	"AuditTraceConfigFile",		true,	""},		// location of audit trace configuration file
 	{TYPE_INTEGER,	"MaxUserTraceLogSize",		true,	10},		// maximum size of user session trace log
@@ -563,9 +561,6 @@ class Config : public RefCounted, public GlobalStorage
 	// GC policy
 	CONFIG_GET_PER_DB_STR(getGCPolicy, KEY_GC_POLICY);
 
-	// Redirection
-	CONFIG_GET_GLOBAL_BOOL(getRedirection, KEY_REDIRECTION);
-
 	CONFIG_GET_PER_DB_INT(getDatabaseGrowthIncrement, KEY_DATABASE_GROWTH_INCREMENT);
 
 	CONFIG_GET_GLOBAL_STR(getAuditTraceConfigFile, KEY_TRACE_CONFIG);

src/remote/client/interface.cpp

@@ -8686,8 +8686,7 @@ static bool get_new_dpb(ClumpletWriter& dpb, const ParametersSet& par, bool loop
  *	Analyze and prepare dpb for attachment to remote server.
  *
  **************************************/
-	bool redirection = Config::getRedirection();
-    if (((loopback || !redirection) && dpb.find(par.address_path)) || dpb.find(par.map_attach))
+    if (dpb.find(par.address_path) || dpb.find(par.map_attach))
 	{
 		status_exception::raise(Arg::Gds(isc_unavailable));
 	}