Skip to content

Commit e1b1b19

Browse files
committed
Ensure ALTER DOMAIN preserves the specified collation, it also fixes #1627: ALTER DOMAIN supporting collation change
1 parent 7fd38e5 commit e1b1b19

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

src/dsql/parse.y

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4281,13 +4281,7 @@ alter_domain_op($alterDomainNode)
42814281
| TO symbol_column_name
42824282
{ setClause($alterDomainNode->renameTo, "DOMAIN NAME", *$2); }
42834283
| TYPE non_array_type
4284-
{
4285-
//// FIXME: ALTER DOMAIN doesn't support collations, and altered domain's
4286-
//// collation is always lost.
4287-
dsql_fld* type = $2;
4288-
type->collate = "";
4289-
setClause($alterDomainNode->type, "DOMAIN TYPE", type);
4290-
}
4284+
{ setClause($alterDomainNode->type, "DOMAIN TYPE", $2);}
42914285
;
42924286

42934287
%type alter_ops(<relationNode>)

0 commit comments

Comments
 (0)