Front-ported pull request #8600

Implement #8598 : Don't fire referential integrity triggers if primary or unique keys haven't changed

Author: hvlad

src/jrd/exe.cpp

@@ -1419,6 +1419,17 @@ void EXE_execute_triggers(thread_db* tdbb,
 	{
 		for (TrigVector::iterator ptr = vector->begin(); ptr != vector->end(); ++ptr)
 		{
+			// The system trigger that implement cascading action can be skipped if
+			// no PK/UK field have been changed by UPDATE.
+
+			if ((which_trig == StmtNode::POST_TRIG) && (trigger_action == TRIGGER_UPDATE) &&
+				(ptr->sysTrigger == fb_sysflag_referential_constraint))
+			{
+				fb_assert(new_rpb);
+				if (!(new_rpb->rpb_runtime_flags & RPB_uk_updated))
+					continue;
+			}
+
 			if (trigger_action == TRIGGER_DDL && ddl_action)
 			{
 				// Skip triggers not matching our action

src/jrd/idx.cpp

@@ -1287,6 +1287,8 @@ void IDX_modify(thread_db* tdbb,
 	RelationPages* relPages = org_rpb->rpb_relation->getPages(tdbb);
 	WIN window(relPages->rel_pg_space_id, -1);
 
+	new_rpb->rpb_runtime_flags &= ~RPB_uk_updated;
+
 	while (BTR_next_index(tdbb, org_rpb->rpb_relation, transaction, &idx, &window))
 	{
 		IndexErrorContext context(new_rpb->rpb_relation, &idx);
@@ -1350,6 +1352,9 @@ void IDX_modify(thread_db* tdbb,
 		{
 			context.raise(tdbb, error_code, new_rpb->rpb_record);
 		}
+
+		if (idx.idx_flags & (idx_primary | idx_unique))
+			new_rpb->rpb_runtime_flags |= RPB_uk_updated;
 	}
 }
 

src/jrd/jrd.h

@@ -144,11 +144,11 @@ class Trigger
 	Firebird::HalfStaticArray<UCHAR, 128> debugInfo;	// Debug info
 	Statement* statement = nullptr;						// Compiled statement
 	bool releaseInProgress = false;
-	bool sysTrigger = false;
+	SSHORT sysTrigger = 0;				// See fb_sysflag in constants.h
 	FB_UINT64 type = 0;					// Trigger type
 	USHORT flags = 0;					// Flags as they are in RDB$TRIGGERS table
 	jrd_rel* relation = nullptr;		// Trigger parent relation
-	QualifiedName name;				// Trigger name
+	QualifiedName name;					// Trigger name
 	MetaName engine;					// External engine name
 	MetaName owner;						// Owner for SQL SECURITY
 	Firebird::string entryPoint;		// External trigger entrypoint

src/jrd/met.epp

@@ -114,7 +114,7 @@ static int blocking_ast_relation(void*);
 static int partners_ast_relation(void*);
 static int rescan_ast_relation(void*);
 static ULONG get_rel_flags_from_FLAGS(USHORT);
-static void get_trigger(thread_db*, jrd_rel*, bid*, bid*, TrigVector**, const QualifiedName&, FB_UINT64, bool,
+static void get_trigger(thread_db*, jrd_rel*, bid*, bid*, TrigVector**, const QualifiedName&, FB_UINT64, SSHORT,
 	USHORT, const MetaName&, const string&, const bid*, TriState ssDefiner);
 static bool get_type(thread_db*, USHORT*, const MetaName&, const TEXT*);
 static void lookup_view_contexts(thread_db*, jrd_rel*);
@@ -123,7 +123,7 @@ static ValueExprNode* parse_field_default_blr(thread_db* tdbb, const MetaName& s
 static BoolExprNode* parse_field_validation_blr(thread_db* tdbb, bid* blob_id, const QualifiedName& name);
 static bool resolve_charset_and_collation(thread_db*, USHORT*, const QualifiedName&, const QualifiedName&);
 static void save_trigger_data(thread_db*, TrigVector**, jrd_rel*, Statement*, blb*, blb*,
-	const QualifiedName*, FB_UINT64, bool, USHORT, const MetaName&, const string&,
+	const QualifiedName*, FB_UINT64, SSHORT, USHORT, const MetaName&, const string&,
 	const bid*, TriState ssDefiner);
 static void scan_partners(thread_db*, jrd_rel*);
 static bool verify_TRG_ignore_perm(thread_db*, const QualifiedName&);
@@ -1983,7 +1983,7 @@ void MET_load_trigger(thread_db* tdbb,
 							triggers,
 							trigger_name,
 							TRG.RDB$TRIGGER_TYPE,
-							(bool) TRG.RDB$SYSTEM_FLAG,
+							TRG.RDB$SYSTEM_FLAG,
 							trig_flags,
 							engine,
 							entryPoint,
@@ -2004,7 +2004,7 @@ void MET_load_trigger(thread_db* tdbb,
 							triggers + trigger_action,
 							trigger_name,
 							(UCHAR) trigger_action,
-							(bool) TRG.RDB$SYSTEM_FLAG,
+							TRG.RDB$SYSTEM_FLAG,
 							trig_flags,
 							engine,
 							entryPoint,
@@ -4612,7 +4612,7 @@ ULONG MET_get_rel_flags_from_TYPE(USHORT type)
 static void get_trigger(thread_db* tdbb, jrd_rel* relation,
 						bid* blob_id, bid* debug_blob_id, TrigVector** ptr,
 						const QualifiedName& name, FB_UINT64 type,
-						bool sys_trigger, USHORT flags,
+						SSHORT sys_trigger, USHORT flags,
 						const MetaName& engine, const string& entryPoint,
 						const bid* body, TriState ssDefiner)
 {
@@ -4993,7 +4993,7 @@ static bool resolve_charset_and_collation(thread_db* tdbb,
 static void save_trigger_data(thread_db* tdbb, TrigVector** ptr, jrd_rel* relation,
 							  Statement* statement, blb* blrBlob, blb* debugInfoBlob,
 							  const QualifiedName* name, FB_UINT64 type,
-							  bool sys_trigger, USHORT flags,
+							  SSHORT sys_trigger, USHORT flags,
 							  const MetaName& engine, const string& entryPoint,
 							  const bid* body, TriState ssDefiner)
 {

src/jrd/req.h

@@ -136,9 +136,10 @@ const USHORT RPB_undo_data		= 0x02;	// data got from undo log
 const USHORT RPB_undo_read		= 0x04;	// read was performed using the undo log
 const USHORT RPB_undo_deleted	= 0x08;	// read was performed using the undo log, primary version is deleted
 const USHORT RPB_just_deleted	= 0x10;	// record was just deleted by us
+const USHORT RPB_uk_updated		= 0x20;	// set by IDX_modify if it insert key into any primary or unique index
 
 const USHORT RPB_UNDO_FLAGS		= (RPB_undo_data | RPB_undo_read | RPB_undo_deleted);
-const USHORT RPB_CLEAR_FLAGS	= (RPB_UNDO_FLAGS | RPB_just_deleted);
+const USHORT RPB_CLEAR_FLAGS	= (RPB_UNDO_FLAGS | RPB_just_deleted | RPB_uk_updated);
 
 // List of active blobs controlled by request